Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153463002: IDL compiler: rename GetShadowObjectTemplate => getShadowObjectTemplate (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

IDL compiler: rename GetShadowObjectTemplate => getShadowObjectTemplate Cleanup, per request: https://codereview.chromium.org/153403002/#msg2 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166381

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-04 04:05:55 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-04 04:23:53 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-04 05:56:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/153463002/1
6 years, 10 months ago (2014-02-04 05:56:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:54:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10732
6 years, 10 months ago (2014-02-04 08:54:32 UTC) #6
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-04 08:55:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/153463002/1
6 years, 10 months ago (2014-02-04 08:55:29 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 11:03:03 UTC) #9
Message was sent while issue was closed. 
Change committed as 166381

Powered by Google App Engine
This is Rietveld 408576698