Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 153403002: IDL compiler: Finish headers (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: Finish headers With this CL, all headers are done! (Identical in Python and Perl) This special-cases 4 interfaces, and fixes one type (attributes => methods), with test case. BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166352

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -3 lines) Patch
M Source/bindings/templates/interface.h View 1 2 chunks +18 lines, -1 line 4 comments Download
M Source/bindings/tests/idls/TestImplements.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 2 chunks +37 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-04 02:52:15 UTC) #1
haraken
LGTM https://codereview.chromium.org/153403002/diff/30001/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/153403002/diff/30001/Source/bindings/templates/interface.h#newcode76 Source/bindings/templates/interface.h:76: static v8::Handle<v8::ObjectTemplate> GetShadowObjectTemplate(v8::Isolate*, WrapperWorldType); GetShadowObjectTemplate => getShadowObjectTemplate Are ...
6 years, 10 months ago (2014-02-04 02:56:14 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-04 02:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/153403002/30001
6 years, 10 months ago (2014-02-04 02:58:39 UTC) #4
Nils Barth (inactive)
https://codereview.chromium.org/153403002/diff/30001/Source/bindings/templates/interface.h File Source/bindings/templates/interface.h (right): https://codereview.chromium.org/153403002/diff/30001/Source/bindings/templates/interface.h#newcode76 Source/bindings/templates/interface.h:76: static v8::Handle<v8::ObjectTemplate> GetShadowObjectTemplate(v8::Isolate*, WrapperWorldType); On 2014/02/04 02:56:15, haraken wrote: ...
6 years, 10 months ago (2014-02-04 04:09:43 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 05:37:04 UTC) #6
Message was sent while issue was closed.
Change committed as 166352

Powered by Google App Engine
This is Rietveld 408576698