arc-bridge: Make ArcAppModelBuilderTest more reliable

arc-bridge: Make ArcAppModelBuilderTest more reliable

ArcAppModelBuilderTest fails spuriously under Valgrind since the thread
interaction is complex. This change makes all async calls explicitly
wait until they have been fulfilled to avoid flake.

BUG=569446, 571260
TBR=afakhry@chromium.org,elijahtaylor@chromium.org
TEST=unit_tests w/valgrind

[lhc(google), 2015-12-19 08:48:41]

lhchavez@google.com changed reviewers:
+ afakhry@chromium.org, elijahtaylor@google.com, lhchavez@google.com

[lhc(google), 2015-12-19 08:50:24]

lhchavez@google.com changed reviewers:
+ elijahtaylor@chromium.org, hidehiko@chromium.org
- elijahtaylor@google.com

[lhc(google), 2015-12-19 15:12:57]

Description was changed from

==========
arc-bridge: Make ArcAppModelBuilderTest more reliable

ArcAppModelBuilderTest fails spuriously under Valgrind since the thread
interaction is complex. This change makes all async calls explicitly
wait until they have been fulfilled to avoid flake.

BUG=569446
TEST=unit_tests w/valgrind
==========

to

==========
arc-bridge: Make ArcAppModelBuilderTest more reliable

ArcAppModelBuilderTest fails spuriously under Valgrind since the thread
interaction is complex. This change makes all async calls explicitly
wait until they have been fulfilled to avoid flake.

BUG=569446
TBR=afakhry@chromium.org,elijahtaylor@chromium.org
TEST=unit_tests w/valgrind
==========

[lhc(google), 2015-12-19 15:13:02]

The CQ bit was checked by lhchavez@google.com

[commit-bot: I haz the power, 2015-12-19 15:13:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534413002/20001

[commit-bot: I haz the power, 2015-12-19 15:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-19 15:13:11]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Lei Zhang, 2015-12-19 23:54:22]

Description was changed from

==========
arc-bridge: Make ArcAppModelBuilderTest more reliable

ArcAppModelBuilderTest fails spuriously under Valgrind since the thread
interaction is complex. This change makes all async calls explicitly
wait until they have been fulfilled to avoid flake.

BUG=569446
TBR=afakhry@chromium.org,elijahtaylor@chromium.org
TEST=unit_tests w/valgrind
==========

to

==========
arc-bridge: Make ArcAppModelBuilderTest more reliable

ArcAppModelBuilderTest fails spuriously under Valgrind since the thread
interaction is complex. This change makes all async calls explicitly
wait until they have been fulfilled to avoid flake.

BUG=569446,571260
TBR=afakhry@chromium.org,elijahtaylor@chromium.org
TEST=unit_tests w/valgrind
==========

[Lei Zhang, 2015-12-19 23:54:44]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2015-12-19 23:54:45]

I added 571260 to BUG= and will hit the CQ button, in hopes that this stops the
failures on the Valgrind bots.

[Lei Zhang, 2015-12-19 23:54:58]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-12-19 23:55:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534413002/40001

[commit-bot: I haz the power, 2015-12-19 23:55:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-19 23:55:05]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Lei Zhang, 2015-12-20 00:00:37]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-12-20 00:00:37]

lgtm

[commit-bot: I haz the power, 2015-12-20 00:00:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1534413002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1534413002/40001

[Lei Zhang, 2015-12-20 00:36:20]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2015-12-20 00:37:01]

On 2015/12/20 00:00:49, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1534413002/40001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1534413002/40001

And aborted due to https://codereview.chromium.org/1534423002

[lhc(google), 2015-12-20 00:37:48]

The CQ bit was unchecked by lhchavez@google.com