Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1534423002: Revert of arc-bridge: Move most methods to Mojo interfaces (Closed)

Created:
5 years ago by lhc(google)
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Matt Giuca, qsr+mojo_chromium.org, tapted, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of arc-bridge: Move most methods to Mojo interfaces (patchset #9 id:160001 of https://codereview.chromium.org/1523643002/ ) Reason for revert: Tests are flaky under Valgrind: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%286%29/builds/35939 This fixes the problem: https://codereview.chromium.org/1534413002/ Original issue's description: > arc-bridge: Move most methods to Mojo interfaces > > This should make the ArcBridgeService surface area smaller by moving all > methods to separate Mojo interfaces. This also lets each individual > service handle its own lifetime and should simplify the Observers > significatively. > > BUG=569446 > TEST=unit_tests, components_unittests > > Committed: https://crrev.com/3bdc0168bb4d055b647dd557d062432c9e835468 > Cr-Commit-Position: refs/heads/master@{#366233} TBR=dcheng@chromium.org,afakhry@chromium.org,elijahtaylor@chromium.org,hidehiko@chromium.org,reveman@chromium.org,xiyuan@chromium.org,lhchavez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=569446 Committed: https://crrev.com/b988466841a1f7b77d0c2bd6824273b7f82b4a36 Cr-Commit-Position: refs/heads/master@{#366286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1026 lines, -801 lines) Patch
M chrome/browser/chromeos/arc/arc_settings_bridge_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_settings_bridge_impl.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/task_management/providers/arc/arc_process_task_provider.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/task_management/providers/arc/arc_process_task_provider.cc View 6 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_item.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 5 chunks +10 lines, -17 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 8 chunks +23 lines, -38 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 11 chunks +29 lines, -44 lines 0 comments Download
M components/arc.gypi View 2 chunks +0 lines, -8 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +0 lines, -9 lines 0 comments Download
M components/arc/arc_bridge_service.h View 7 chunks +121 lines, -49 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 chunk +13 lines, -20 lines 0 comments Download
M components/arc/arc_bridge_service_impl.h View 3 chunks +52 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 3 chunks +191 lines, -1 line 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 7 chunks +17 lines, -9 lines 0 comments Download
D components/arc/common/app.mojom View 1 chunk +0 lines, -62 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 1 chunk +266 lines, -32 lines 0 comments Download
D components/arc/common/input.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D components/arc/common/notifications.mojom View 1 chunk +0 lines, -70 lines 0 comments Download
D components/arc/common/power.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
D components/arc/common/process.mojom View 1 chunk +0 lines, -90 lines 0 comments Download
D components/arc/common/settings.mojom View 1 chunk +0 lines, -19 lines 0 comments Download
M components/arc/input/arc_input_bridge_impl.h View 5 chunks +8 lines, -11 lines 0 comments Download
M components/arc/input/arc_input_bridge_impl.cc View 7 chunks +13 lines, -26 lines 0 comments Download
D components/arc/test/fake_app_instance.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/arc/test/fake_app_instance.cc View 1 chunk +0 lines, -105 lines 0 comments Download
M components/arc/test/fake_arc_bridge_instance.h View 1 chunk +18 lines, -0 lines 0 comments Download
M components/arc/test/fake_arc_bridge_instance.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/arc/test/fake_arc_bridge_service.h View 2 chunks +86 lines, -0 lines 0 comments Download
M components/arc/test/fake_arc_bridge_service.cc View 3 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lhc(google)
Created Revert of arc-bridge: Move most methods to Mojo interfaces
5 years ago (2015-12-19 15:15:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534423002/1
5 years ago (2015-12-19 15:15:38 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-19 15:15:40 UTC) #4
dcheng
lgtm
5 years ago (2015-12-20 00:24:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1534423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1534423002/1
5 years ago (2015-12-20 00:25:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-20 00:26:06 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-20 00:27:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b988466841a1f7b77d0c2bd6824273b7f82b4a36
Cr-Commit-Position: refs/heads/master@{#366286}

Powered by Google App Engine
This is Rietveld 408576698