Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: media/audio/win/audio_low_latency_input_win_unittest.cc

Issue 1534273002: Switch to standard integer types in media/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/win/audio_low_latency_input_win_unittest.cc
diff --git a/media/audio/win/audio_low_latency_input_win_unittest.cc b/media/audio/win/audio_low_latency_input_win_unittest.cc
index 6a8e8a9737d41f4652389d2841ebe6532677ee3f..3190b7bae24ac8110d5ecbabb706018b87cb7c00 100644
--- a/media/audio/win/audio_low_latency_input_win_unittest.cc
+++ b/media/audio/win/audio_low_latency_input_win_unittest.cc
@@ -5,7 +5,6 @@
#include <windows.h>
#include <mmsystem.h>
-#include "base/basictypes.h"
#include "base/environment.h"
#include "base/files/file_util.h"
#include "base/memory/scoped_ptr.h"
@@ -41,7 +40,7 @@ class MockAudioInputCallback : public AudioInputStream::AudioInputCallback {
MOCK_METHOD4(OnData,
void(AudioInputStream* stream,
const AudioBus* src,
- uint32 hardware_delay_bytes,
+ uint32_t hardware_delay_bytes,
double volume));
MOCK_METHOD1(OnError, void(AudioInputStream* stream));
};
@@ -63,7 +62,7 @@ class FakeAudioInputCallback : public AudioInputStream::AudioInputCallback {
void OnData(AudioInputStream* stream,
const AudioBus* src,
- uint32 hardware_delay_bytes,
+ uint32_t hardware_delay_bytes,
double volume) override {
EXPECT_GE(hardware_delay_bytes, 0u);
EXPECT_LT(hardware_delay_bytes, 0xFFFFu); // Arbitrarily picked.
@@ -107,7 +106,7 @@ class WriteToFileAudioSink : public AudioInputStream::AudioInputCallback {
~WriteToFileAudioSink() override {
size_t bytes_written = 0;
while (bytes_written < bytes_to_write_) {
- const uint8* chunk;
+ const uint8_t* chunk;
int chunk_size;
// Stop writing if no more data is available.
@@ -125,11 +124,11 @@ class WriteToFileAudioSink : public AudioInputStream::AudioInputCallback {
// AudioInputStream::AudioInputCallback implementation.
void OnData(AudioInputStream* stream,
const AudioBus* src,
- uint32 hardware_delay_bytes,
+ uint32_t hardware_delay_bytes,
double volume) override {
EXPECT_EQ(bits_per_sample_, 16);
const int num_samples = src->frames() * src->channels();
- scoped_ptr<int16> interleaved(new int16[num_samples]);
+ scoped_ptr<int16_t> interleaved(new int16_t[num_samples]);
const int bytes_per_sample = sizeof(*interleaved);
src->ToInterleaved(src->frames(), bytes_per_sample, interleaved.get());
@@ -137,7 +136,7 @@ class WriteToFileAudioSink : public AudioInputStream::AudioInputCallback {
// fwrite() calls in the audio callback. The complete buffer will be
// written to file in the destructor.
const int size = bytes_per_sample * num_samples;
- if (buffer_.Append((const uint8*)interleaved.get(), size)) {
+ if (buffer_.Append((const uint8_t*)interleaved.get(), size)) {
bytes_to_write_ += size;
}
}
@@ -360,8 +359,8 @@ TEST(WinAudioInputTest, WASAPIAudioInputStreamTestPacketSizes) {
MockAudioInputCallback sink;
// Derive the expected size in bytes of each recorded packet.
- uint32 bytes_per_packet = aisw.channels() * aisw.frames_per_buffer() *
- (aisw.bits_per_sample() / 8);
+ uint32_t bytes_per_packet =
+ aisw.channels() * aisw.frames_per_buffer() * (aisw.bits_per_sample() / 8);
// We use 10ms packets and will run the test until ten packets are received.
// All should contain valid packets of the same size and a valid delay

Powered by Google App Engine
This is Rietveld 408576698