Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
diff --git a/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc b/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
index 5b50fc5a46042f665f5fdc4f05a4c431098127ec..d48c6f8b3c4671f56baba05c0e836a25a4845274 100644
--- a/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
+++ b/remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc
@@ -76,12 +76,12 @@ class SslHmacChannelAuthenticatorTest : public testing::Test {
client_fake_socket_->PairWith(host_fake_socket_.get());
client_auth_->SecureAndAuthenticate(
- client_fake_socket_.Pass(),
+ std::move(client_fake_socket_),
base::Bind(&SslHmacChannelAuthenticatorTest::OnClientConnected,
base::Unretained(this)));
host_auth_->SecureAndAuthenticate(
- host_fake_socket_.Pass(),
+ std::move(host_fake_socket_),
base::Bind(&SslHmacChannelAuthenticatorTest::OnHostConnected,
base::Unretained(this), std::string("ref argument value")));
@@ -122,13 +122,13 @@ class SslHmacChannelAuthenticatorTest : public testing::Test {
DCHECK_EQ(ref_argument, "ref argument value");
host_callback_.OnDone(error, socket.get());
- host_socket_ = socket.Pass();
+ host_socket_ = std::move(socket);
}
void OnClientConnected(int error, scoped_ptr<P2PStreamSocket> socket) {
client_auth_.reset();
client_callback_.OnDone(error, socket.get());
- client_socket_ = socket.Pass();
+ client_socket_ = std::move(socket);
}
base::MessageLoop message_loop_;

Powered by Google App Engine
This is Rietveld 408576698