remoting/protocol/pseudotcp_adapter.cc - Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/pseudotcp_adapter.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/pseudotcp_adapter.cc

diff --git a/remoting/protocol/pseudotcp_adapter.cc b/remoting/protocol/pseudotcp_adapter.cc

index 2ed9cb7354a28be0e1204657f02e7606ef63ea2b..dba19b8338b1407e2dc98429aeda3a124c45474a 100644

--- a/remoting/protocol/pseudotcp_adapter.cc

+++ b/remoting/protocol/pseudotcp_adapter.cc

@@ -114,7 +114,7 @@ class PseudoTcpAdapter::Core : public cricket::IPseudoTcpNotify,

PseudoTcpAdapter::Core::Core(scoped_ptr<P2PDatagramSocket> socket)

: pseudo_tcp_(this, 0),

- socket_(socket.Pass()),

+ socket_(std::move(socket)),

write_waits_for_send_(false),

waiting_write_position_(false),

socket_write_pending_(false) {

@@ -449,7 +449,7 @@ void PseudoTcpAdapter::Core::CheckWriteComplete() {

// Public interface implementation.

PseudoTcpAdapter::PseudoTcpAdapter(scoped_ptr<P2PDatagramSocket> socket)

- : core_(new Core(socket.Pass())) {

+ : core_(new Core(std::move(socket))) {

}

PseudoTcpAdapter::~PseudoTcpAdapter() {