remoting/protocol/protobuf_message_parser.h - Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/protobuf_message_parser.h

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/protobuf_message_parser.h

diff --git a/remoting/protocol/protobuf_message_parser.h b/remoting/protocol/protobuf_message_parser.h

index 68840b1fc6d3722a9ca4a556a39b5c89262353a6..e70328a59b1c7dcf02814c75ff5ec4712aa0fac4 100644

--- a/remoting/protocol/protobuf_message_parser.h

+++ b/remoting/protocol/protobuf_message_parser.h

@@ -48,7 +48,7 @@ class ProtobufMessageParser {

LOG(WARNING) << "Received message that is not a valid protocol buffer.";

} else {

DCHECK_EQ(stream.position(), buffer->total_bytes());

- message_received_callback_.Run(message.Pass(), done_task);

+ message_received_callback_.Run(std::move(message), done_task);

}