remoting/protocol/message_reader.cc - Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/message_reader.cc

Issue 1534193004: Use std::move() instead of scoped_ptr<>::Pass(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/message_reader.cc

diff --git a/remoting/protocol/message_reader.cc b/remoting/protocol/message_reader.cc

index ab812daf9859ba04de95b8c24a3273f580b5e084..75b29492fb6450a57995555e0e7763db40a08f45 100644

--- a/remoting/protocol/message_reader.cc

+++ b/remoting/protocol/message_reader.cc

@@ -126,7 +126,7 @@ void MessageReader::OnDataReceived(net::IOBuffer* data, int data_size) {

void MessageReader::RunCallback(scoped_ptr<CompoundBuffer> message) {

if (!message_received_callback_.is_null()){

message_received_callback_.Run(

- message.Pass(),

+ std::move(message),

base::Bind(&MessageReader::OnMessageDone, weak_factory_.GetWeakPtr()));

}