Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api.h

Issue 1534123002: [Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/permissions/permissions_api.h
diff --git a/chrome/browser/extensions/api/permissions/permissions_api.h b/chrome/browser/extensions/api/permissions/permissions_api.h
index cff5332671d387d654d0bacf9fe152a77f90447b..e94b305501ea385b5f90530b2ffc0b48eb372ebb 100644
--- a/chrome/browser/extensions/api/permissions/permissions_api.h
+++ b/chrome/browser/extensions/api/permissions/permissions_api.h
@@ -51,8 +51,7 @@ class PermissionsRemoveFunction : public ChromeSyncExtensionFunction {
};
// chrome.permissions.request
-class PermissionsRequestFunction : public ChromeAsyncExtensionFunction,
- public ExtensionInstallPrompt::Delegate {
+class PermissionsRequestFunction : public ChromeAsyncExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("permissions.request", PERMISSIONS_REQUEST)
@@ -62,10 +61,6 @@ class PermissionsRequestFunction : public ChromeAsyncExtensionFunction,
static void SetAutoConfirmForTests(bool should_proceed);
static void SetIgnoreUserGestureForTests(bool ignore);
- // ExtensionInstallPrompt::Delegate:
- void InstallUIProceed() override;
- void InstallUIAbort(bool user_initiated) override;
-
protected:
~PermissionsRequestFunction() override;
@@ -73,8 +68,12 @@ class PermissionsRequestFunction : public ChromeAsyncExtensionFunction,
bool RunAsync() override;
private:
+ void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
+
scoped_ptr<ExtensionInstallPrompt> install_ui_;
scoped_ptr<const PermissionSet> requested_permissions_;
+
+ DISALLOW_COPY_AND_ASSIGN(PermissionsRequestFunction);
Avi (use Gerrit) 2015/12/29 03:10:45 base/macros.h
Devlin 2016/01/04 22:59:23 Done.
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698