[Extensions] Migrate ExtensionInstallPrompt::Delegate to be a callback

chrome/browser/extensions/api/permissions/permissions_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_PERMISSIONS_PERMISSIONS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_PERMISSIONS_PERMISSIONS_API_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 33 matching lines @@
   DECLARE_EXTENSION_FUNCTION("permissions.remove", PERMISSIONS_REMOVE)
 
  protected:
   ~PermissionsRemoveFunction() override {}
 
   // ExtensionFunction:
   bool RunSync() override;
 };
 
 // chrome.permissions.request
-class PermissionsRequestFunction : public ChromeAsyncExtensionFunction,
-                                   public ExtensionInstallPrompt::Delegate {
+class PermissionsRequestFunction : public ChromeAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("permissions.request", PERMISSIONS_REQUEST)
 
   PermissionsRequestFunction();
 
   // FOR TESTS ONLY to bypass the confirmation UI.
   static void SetAutoConfirmForTests(bool should_proceed);
   static void SetIgnoreUserGestureForTests(bool ignore);
 
-  // ExtensionInstallPrompt::Delegate:
-  void InstallUIProceed() override;
-  void InstallUIAbort(bool user_initiated) override;
-
  protected:
   ~PermissionsRequestFunction() override;
 
   // ExtensionFunction:
   bool RunAsync() override;
 
  private:
+  void OnInstallPromptDone(ExtensionInstallPrompt::Result result);
+
   scoped_ptr<ExtensionInstallPrompt> install_ui_;
   scoped_ptr<const PermissionSet> requested_permissions_;
+
+  DISALLOW_COPY_AND_ASSIGN(PermissionsRequestFunction);

[Avi (use Gerrit), 2015/12/29 03:10:45]

base/macros.h

[Devlin, 2016/01/04 22:59:23]

Done.

 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_PERMISSIONS_PERMISSIONS_API_H_