Issue 1534033003: VM: Fix crash parsing metadata with a closure as a const constructor argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1534033003: VM: Fix crash parsing metadata with a closure as a const constructor argument. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix crash parsing metadata with a closure as a const constructor argument. BUG=http://dartbug.com/25240 R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/c740fea5450707e077c8088157df724acabc673a

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -0 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/metadata_allowed_values_test.dart	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

5 years ago (2015-12-18 01:18:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c740fea5450707e077c8088157df724acabc673a (presubmit successful).