runtime/vm/parser.cc - Issue 1534033003: VM: Fix crash parsing metadata with a closure as a const constructor argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1534033003: VM: Fix crash parsing metadata with a closure as a const constructor argument. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 09dab6cfb548cb1423f67b9de9b0e02d6b14ebf3..217354aad0bd03e4bfcfbb13195b5e7ae7750ef2 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -1065,6 +1065,7 @@ RawObject* Parser::ParseMetadata(const Field& meta_data) {

new ParsedFunction(thread, fake_function);

Parser parser(script, parsed_function, token_pos);

parser.set_current_class(owner_class);

+ parser.OpenFunctionBlock(fake_function);

RawObject* metadata = parser.EvaluateMetadata();

return metadata;

« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »