Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 153393002: Accept smaller icons for the extension uninstall dialog for bookmark apps. (Closed)

Created:
6 years, 10 months ago by calamity
Modified:
6 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Accept smaller icons for the extension uninstall dialog for bookmark apps. The extension uninstall dialog currently only accepts 128x128 or larger icons. Bookmark apps may not have this icon size. Since the 48x48 icon is shown in the launcher, bookmark apps should use that icon in the extension uninstall dialog to prevent the case of having an icon in the launcher, but not in the uninstall dialog. BUG=318607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248863

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/extensions/extension_uninstall_dialog.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
calamity
6 years, 10 months ago (2014-02-04 02:39:47 UTC) #1
benwells
lgtm
6 years, 10 months ago (2014-02-04 06:25:42 UTC) #2
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 10 months ago (2014-02-04 07:03:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/153393002/1
6 years, 10 months ago (2014-02-04 07:06:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:52:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222912
6 years, 10 months ago (2014-02-04 07:52:52 UTC) #6
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 10 months ago (2014-02-04 23:39:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/153393002/1
6 years, 10 months ago (2014-02-04 23:41:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/153393002/1
6 years, 10 months ago (2014-02-05 01:38:03 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 05:32:28 UTC) #10
Message was sent while issue was closed.
Change committed as 248863

Powered by Google App Engine
This is Rietveld 408576698