Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5551)

Unified Diff: chrome/browser/extensions/extension_uninstall_dialog.cc

Issue 153393002: Accept smaller icons for the extension uninstall dialog for bookmark apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_uninstall_dialog.cc
diff --git a/chrome/browser/extensions/extension_uninstall_dialog.cc b/chrome/browser/extensions/extension_uninstall_dialog.cc
index 3020c04f686daa56b21a3ec6e20374d918565344..904f1117b3462626a817ef81df48009fd9c10a27 100644
--- a/chrome/browser/extensions/extension_uninstall_dialog.cc
+++ b/chrome/browser/extensions/extension_uninstall_dialog.cc
@@ -73,9 +73,13 @@ void ExtensionUninstallDialog::ConfirmUninstall(
const extensions::Extension* extension) {
DCHECK(ui_loop_ == base::MessageLoop::current());
extension_ = extension;
+ // Bookmark apps may not have 128x128 icons so accept 48x48 icons.
+ const int icon_size = extension_->from_bookmark()
+ ? extension_misc::EXTENSION_ICON_MEDIUM
+ : extension_misc::EXTENSION_ICON_LARGE;
extensions::ExtensionResource image = extensions::IconsInfo::GetIconResource(
extension_,
- extension_misc::EXTENSION_ICON_LARGE,
+ icon_size,
ExtensionIconSet::MATCH_BIGGER);
// Load the icon whose pixel size is large enough to be displayed under
// maximal supported scale factor. UI code will scale the icon down if needed.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698