Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 1533643004: Always fire refresh tokens loaded on ChromeOS. (Closed)

Created:
5 years ago by knn
Modified:
5 years ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Always fire refresh tokens loaded on ChromeOS. Unlike other platforms, ChromeOS does not trigger ProfileOAuth2TokenService#LoadCredentials(). As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded notification before fetching the account info. This cl ensures that notification is triggered correctly in the simplest way. However this should ideally be handled within the OAuth2TokenServiceDelegate or plumbed in a more explicit manner. BUG=557906 NOTRY=true Review URL: https://codereview.chromium.org/1523743003 Cr-Commit-Position: refs/heads/master@{#365491} (cherry picked from commit 91d55c621307c578c233e3a07d896ce763abbae2) Committed: https://chromium.googlesource.com/chromium/src/+/2211e504b4f3ca5a823388378619d96ad3263d18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/chromeos/login/signin/oauth2_login_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
knn
5 years ago (2015-12-17 06:47:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2211e504b4f3ca5a823388378619d96ad3263d18.

Powered by Google App Engine
This is Rietveld 408576698