Always fire refresh tokens loaded on ChromeOS.

Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true

Committed: https://crrev.com/91d55c621307c578c233e3a07d896ce763abbae2
Cr-Commit-Position: refs/heads/master@{#365491}

[knn, 2015-12-15 09:25:07]

knn@chromium.org changed reviewers:
+ achuith@chromium.org, rogerta@chromium.org

[knn, 2015-12-15 09:25:07]

PTAL. Thanks!

Account Info is only fetched if RefreshTokensLoaded notification is triggered.
This is triggered on other(non-CrOS) platforms when it is actually loaded (if
signed in) or when the signin manager is initialized.

CrOS seems to have multiple methods of loading the refresh tokens, (which missed
in https://codereview.chromium.org/1380103004, Sorry!)
I think I have covered all of them now.

PTAL. Unfortunately I am on vacation presently and don't have a device to check
this.

[achuithb, 2015-12-15 22:16:47]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 22:17:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523743003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523743003/1

[achuithb, 2015-12-15 22:18:42]

achuith@chromium.org changed reviewers:
+ dzhioev@chromium.org

[achuithb, 2015-12-15 22:18:42]

Pavel, can you review, and verify that this fixes the issue we're seeing on
cros?

https://codereview.chromium.org/1523743003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/signin/oauth2_login_manager.cc (right):

https://codereview.chromium.org/1523743003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/signin/oauth2_login_manager.cc:206: // TODO(knn):
Figure out the right way to plumb this.
please reference a bug here.

[commit-bot: I haz the power, 2015-12-15 23:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 23:07:10]

Dry run: This issue passed the CQ dry run.

[dzhioev (left Google), 2015-12-15 23:25:11]

On 2015/12/15 23:07:10, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

LGTM

[dzhioev (left Google), 2015-12-15 23:25:12]

On 2015/12/15 23:07:10, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

LGTM

[knn, 2015-12-16 06:57:28]

Thanks for verifying and reviewing Pavel!
I'll submit this as is.
Roger, Achuith:
Feel free to leave additional comments, I am assuming they will be nits which
I'll handle in a followup cl.

https://codereview.chromium.org/1523743003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/signin/oauth2_login_manager.cc (right):

https://codereview.chromium.org/1523743003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/signin/oauth2_login_manager.cc:206: // TODO(knn):
Figure out the right way to plumb this.
On 2015/12/15 22:18:42, achuithb wrote:
> please reference a bug here.

Done.

[knn, 2015-12-16 06:58:07]

Description was changed from

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
==========

to

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true
==========

[knn, 2015-12-16 06:58:23]

The CQ bit was checked by knn@chromium.org

[knn, 2015-12-16 06:58:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1523743003/#ps20001
(title: "insert bug no")

[commit-bot: I haz the power, 2015-12-16 06:58:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523743003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523743003/20001

[commit-bot: I haz the power, 2015-12-16 07:04:07]

Description was changed from

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true
==========

to

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true
==========

[commit-bot: I haz the power, 2015-12-16 07:04:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 07:05:02]

Description was changed from

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true
==========

to

==========
Always fire refresh tokens loaded on ChromeOS.

Unlike other platforms, ChromeOS does not trigger
ProfileOAuth2TokenService#LoadCredentials().
As of http://crrev.com/1380103004 we wait for RefreshTokensLoaded
notification before fetching the account info.

This cl ensures that notification is triggered correctly in the simplest
way. However this should ideally be handled within the
OAuth2TokenServiceDelegate or plumbed in a more explicit manner.

BUG=557906
NOTRY=true

Committed: https://crrev.com/91d55c621307c578c233e3a07d896ce763abbae2
Cr-Commit-Position: refs/heads/master@{#365491}
==========

[commit-bot: I haz the power, 2015-12-16 07:05:03]

Patchset 2 (id:??) landed as
https://crrev.com/91d55c621307c578c233e3a07d896ce763abbae2
Cr-Commit-Position: refs/heads/master@{#365491}

[achuithb, 2015-12-16 07:09:07]

lgtm