content/browser/download/download_request_handle.h - Issue 1533583002: [Downloads] Factor out request handling logic between DRH and UD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_request_handle.h

Issue 1533583002: [Downloads] Factor out request handling logic between DRH and UD. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Why aren't there tests for sniffed MIME types? Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_manager_impl_unittest.cc ('K') | « content/browser/download/download_request_core.cc ('k') | content/browser/download/download_request_handle.cc » ('j') | content/browser/download/url_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/download/download_request_handle.h

diff --git a/content/browser/download/download_request_handle.h b/content/browser/download/download_request_handle.h

index 3e237758ed810df50e58ced81dbccb035406a4e3..5d047c759100235176678230085abb6717e989e2 100644

--- a/content/browser/download/download_request_handle.h

+++ b/content/browser/download/download_request_handle.h

@@ -24,7 +24,7 @@ class WebContents;

// DownloadRequestHandleInterface is defined for mocking purposes.

class CONTENT_EXPORT DownloadRequestHandleInterface {

public:

- virtual ~DownloadRequestHandleInterface() {}

+ virtual ~DownloadRequestHandleInterface();

// These functions must be called on the UI thread.

virtual WebContents* GetWebContents() const = 0;