Add VisualBench switch to extra_config

Add VisualBench switch to extra_config

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1533523003

Committed: https://skia.googlesource.com/skia/+/64673afe1a25ddd2d82d955ff7d9f7b3e026205f

[joshua.litt, 2015-12-16 19:58:45]

Description was changed from

==========
Add VisualBench switch to extra_config

BUG=skia:
==========

to

==========
Add VisualBench switch to extra_config

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2015-12-16 19:59:11]

joshualitt@google.com changed reviewers:
+ borenet@google.com, joshualitt@google.com

[joshualitt, 2015-12-16 19:59:12]

might have done this wrong

[borenet, 2015-12-16 20:13:58]

https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py
File tools/buildbot_spec.py (right):

https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:148: gyp_defs['skia_use_sdl'] = '1'
Nit 2-space indent

https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
tools/buildbot_spec.py:149: builder_dict['target'] = 'visualbench'
This goes in build_targets_from_builder_dict (line 184)

[joshualitt, 2015-12-16 20:21:02]

On 2015/12/16 20:13:58, borenet wrote:
> https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py
> File tools/buildbot_spec.py (right):
> 
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> tools/buildbot_spec.py:148: gyp_defs['skia_use_sdl'] = '1'
> Nit 2-space indent
> 
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> tools/buildbot_spec.py:149: builder_dict['target'] = 'visualbench'
> This goes in build_targets_from_builder_dict (line 184)

feedback inc

[borenet, 2015-12-16 20:23:20]

On 2015/12/16 20:21:02, joshualitt wrote:
> On 2015/12/16 20:13:58, borenet wrote:
> > https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py
> > File tools/buildbot_spec.py (right):
> > 
> >
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> > tools/buildbot_spec.py:148: gyp_defs['skia_use_sdl'] = '1'
> > Nit 2-space indent
> > 
> >
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> > tools/buildbot_spec.py:149: builder_dict['target'] = 'visualbench'
> > This goes in build_targets_from_builder_dict (line 184)
> 
> feedback inc

Can you run the script to generate new JSON expectations?

[joshualitt, 2015-12-16 20:35:00]

On 2015/12/16 20:23:20, borenet wrote:
> On 2015/12/16 20:21:02, joshualitt wrote:
> > On 2015/12/16 20:13:58, borenet wrote:
> > > https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py
> > > File tools/buildbot_spec.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> > > tools/buildbot_spec.py:148: gyp_defs['skia_use_sdl'] = '1'
> > > Nit 2-space indent
> > > 
> > >
> >
>
https://codereview.chromium.org/1533523003/diff/1/tools/buildbot_spec.py#newc...
> > > tools/buildbot_spec.py:149: builder_dict['target'] = 'visualbench'
> > > This goes in build_targets_from_builder_dict (line 184)
> > 
> > feedback inc
> 
> Can you run the script to generate new JSON expectations?

done

[borenet, 2015-12-16 20:36:00]

LGTM

[joshualitt, 2015-12-16 20:36:40]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-12-16 20:36:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533523003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533523003/40001

[commit-bot: I haz the power, 2015-12-16 20:54:21]

Description was changed from

==========
Add VisualBench switch to extra_config

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add VisualBench switch to extra_config

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/64673afe1a25ddd2d82d955ff7d9f7b3e026205f
==========

[commit-bot: I haz the power, 2015-12-16 20:54:22]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/64673afe1a25ddd2d82d955ff7d9f7b3e026205f