Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/buildbot_spec.py

Issue 1533523003: Add VisualBench switch to extra_config (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rerun test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/buildbot_spec.py
diff --git a/tools/buildbot_spec.py b/tools/buildbot_spec.py
index b62fe61fc54c2d394b72b8740ee1be2f0f9ef733..8049b618719e2d143751c96cebaffacf2a5b307b 100755
--- a/tools/buildbot_spec.py
+++ b/tools/buildbot_spec.py
@@ -143,6 +143,10 @@ def gyp_defines(builder_dict):
builder_dict.get('cpu_or_gpu_value') == 'Mesa'):
gyp_defs['skia_mesa'] = '1'
+ # VisualBench
+ if builder_dict.get('extra_config') == 'VisualBench':
+ gyp_defs['skia_use_sdl'] = '1'
+
# skia_use_android_framework_defines.
if builder_dict.get('extra_config') == 'Android_FrameworkDefs':
gyp_defs['skia_use_android_framework_defines'] = '1'
@@ -185,8 +189,10 @@ def build_targets_from_builder_dict(builder_dict, do_test_steps, do_perf_steps):
t = []
if do_test_steps:
t.append('dm')
- if do_perf_steps:
- t.append('nanobench')
+ if do_perf_steps and builder_dict.get('extra_config') == 'VisualBench':
+ t.append('visualbench')
+ elif do_perf_steps:
+ t.append('nanobench')
if t:
return t
else:
@@ -319,6 +325,7 @@ def self_test():
'Build-Ubuntu-GCC-x86_64-Release-ANGLE',
'Housekeeper-PerCommit',
'Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot',
+ 'Perf-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-VisualBench',
'Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug',
'Perf-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Release-Appurify',
'Test-Android-GCC-Nexus6-GPU-Adreno420-Arm7-Debug',
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698