Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 153343003: Move Clipboard-related code from core/dom to core/clipboard (Closed)

Created:
6 years, 10 months ago by adamk
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, Inactive, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Move Clipboard-related code from core/dom to core/clipboard A lot of this stuff landed in dom when it was ousted from core/platform; most of these classes would be happier in blink_platform (save for Clipboard, DataTransferItem, and DataTransferItemList, which all have associated IDL files), but due to a few File dependencies it's not trivial to move there. But since it doesn't belong in dom (they're not related to Document structure), a new clipboard directory seems the best bet. R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166738

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -2099 lines) Patch
M Source/bindings/v8/custom/V8EventCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/clipboard/Clipboard.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/clipboard/Clipboard.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
A + Source/core/clipboard/Clipboard.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/ClipboardAccessPolicy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/DataObject.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/clipboard/DataObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/clipboard/DataObjectItem.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/DataObjectItem.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/clipboard/DataTransferItem.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/DataTransferItem.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + Source/core/clipboard/DataTransferItem.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/DataTransferItemList.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/DataTransferItemList.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + Source/core/clipboard/DataTransferItemList.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/Pasteboard.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/clipboard/Pasteboard.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 7 chunks +15 lines, -14 lines 0 comments Download
D Source/core/dom/Clipboard.h View 1 chunk +0 lines, -140 lines 0 comments Download
D Source/core/dom/Clipboard.cpp View 1 chunk +0 lines, -525 lines 0 comments Download
D Source/core/dom/Clipboard.idl View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/dom/ClipboardAccessPolicy.h View 1 chunk +0 lines, -37 lines 0 comments Download
D Source/core/dom/DataObject.h View 1 chunk +0 lines, -109 lines 0 comments Download
D Source/core/dom/DataObject.cpp View 1 chunk +0 lines, -269 lines 0 comments Download
D Source/core/dom/DataObjectItem.h View 1 chunk +0 lines, -95 lines 0 comments Download
D Source/core/dom/DataObjectItem.cpp View 1 chunk +0 lines, -174 lines 0 comments Download
D Source/core/dom/DataTransferItem.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/core/dom/DataTransferItem.cpp View 1 chunk +0 lines, -101 lines 0 comments Download
D Source/core/dom/DataTransferItem.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/dom/DataTransferItemList.h View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/core/dom/DataTransferItemList.cpp View 1 chunk +0 lines, -110 lines 0 comments Download
D Source/core/dom/DataTransferItemList.idl View 1 chunk +0 lines, -40 lines 0 comments Download
D Source/core/dom/Pasteboard.h View 1 chunk +0 lines, -79 lines 0 comments Download
D Source/core/dom/Pasteboard.cpp View 1 chunk +0 lines, -139 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/editing/EditorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ClipboardEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/page/DragData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DraggedIsolatedFileSystem.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DragClientImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsFrontendImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDragData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
adamk
6 years, 10 months ago (2014-02-07 18:38:43 UTC) #1
dcheng
On 2014/02/07 18:38:43, adamk wrote: Would it make more sense to leave Clipboard where it ...
6 years, 10 months ago (2014-02-07 18:40:15 UTC) #2
adamk
On 2014/02/07 18:40:15, dcheng wrote: > Would it make more sense to leave Clipboard where ...
6 years, 10 months ago (2014-02-07 18:44:53 UTC) #3
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-07 18:50:19 UTC) #4
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 10 months ago (2014-02-07 18:50:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/153343003/1
6 years, 10 months ago (2014-02-07 18:50:59 UTC) #6
adamk
6 years, 10 months ago (2014-02-07 21:11:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r166738 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698