[debugger] step on every assignment in a destructuring assignment.

[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N

Committed: https://crrev.com/831b7ee3aa966a2920f3950a73c981dfe37a1c69
Cr-Commit-Position: refs/heads/master@{#33000}

[Yang, 2015-12-21 13:24:16]

On 2015/12/21 13:23:50, Yang wrote:

currently blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4636

[Yang, 2015-12-21 13:25:58]

Description was changed from

==========
[debugger] step on every assignment in a destructuring assignment.

R=adamk@chromium.org, caitpotter88@gmail.com
BUG=v8:811
LOG=N
==========

to

==========
[debugger] step on every assignment in a destructuring assignment.

R=adamk@chromium.org, caitpotter88@gmail.com
BUG=v8:811
LOG=N
==========

[Yang, 2015-12-21 13:25:58]

yangguo@chromium.org changed reviewers:
+ littledan@chromium.org
- adamk@chromium.org

[Yang, 2015-12-21 13:26:13]

Description was changed from

==========
[debugger] step on every assignment in a destructuring assignment.

R=adamk@chromium.org, caitpotter88@gmail.com
BUG=v8:811
LOG=N
==========

to

==========
[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N
==========

[Yang, 2015-12-21 20:19:27]

On 2015/12/21 13:24:16, Yang wrote:
> On 2015/12/21 13:23:50, Yang wrote:
> 
> currently blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4636

ping

[caitp (gmail), 2015-12-21 20:25:13]

On 2015/12/21 20:19:27, Yang wrote:
> On 2015/12/21 13:24:16, Yang wrote:
> > On 2015/12/21 13:23:50, Yang wrote:
> > 
> > currently blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4636
> 
> ping

Maybe it's worth having a similar test for --destructuring-bind, as this should
affect that as well

It looks right though

[Yang, 2015-12-21 20:30:05]

On 2015/12/21 20:25:13, caitp wrote:
> On 2015/12/21 20:19:27, Yang wrote:
> > On 2015/12/21 13:24:16, Yang wrote:
> > > On 2015/12/21 13:23:50, Yang wrote:
> > > 
> > > currently blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4636
> > 
> > ping
> 
> Maybe it's worth having a similar test for --destructuring-bind, as this
should
> affect that as well
> 
> It looks right though

I planned to do one after another. Default parameters is another one that I'd
like to add a test for and maybe fix.

[Dan Ehrenberg, 2015-12-21 20:45:13]

lgtm

[Yang, 2015-12-22 07:44:03]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-12-22 07:44:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533313002/1

[Yang, 2015-12-22 07:47:55]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2015-12-22 08:01:47]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-12-22 08:01:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/1533313002/#ps20001
(title: "extend test case")

[commit-bot: I haz the power, 2015-12-22 08:02:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1533313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1533313002/20001

[commit-bot: I haz the power, 2015-12-22 08:20:50]

Description was changed from

==========
[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N
==========

to

==========
[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N
==========

[commit-bot: I haz the power, 2015-12-22 08:20:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-22 08:21:41]

Description was changed from

==========
[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N
==========

to

==========
[debugger] step on every assignment in a destructuring assignment.

R=caitpotter88@gmail.com, littledan@chromium.org
BUG=v8:811
LOG=N

Committed: https://crrev.com/831b7ee3aa966a2920f3950a73c981dfe37a1c69
Cr-Commit-Position: refs/heads/master@{#33000}
==========

[commit-bot: I haz the power, 2015-12-22 08:21:42]

Patchset 2 (id:??) landed as
https://crrev.com/831b7ee3aa966a2920f3950a73c981dfe37a1c69
Cr-Commit-Position: refs/heads/master@{#33000}