Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1533313002: [debugger] step on every assignment in a destructuring assignment. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] step on every assignment in a destructuring assignment. R=caitpotter88@gmail.com, littledan@chromium.org BUG=v8:811 LOG=N Committed: https://crrev.com/831b7ee3aa966a2920f3950a73c981dfe37a1c69 Cr-Commit-Position: refs/heads/master@{#33000}

Patch Set 1 #

Patch Set 2 : extend test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -1 line) Patch
M src/parsing/pattern-rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/harmony/debug-step-destructuring-assignment.js View 1 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Yang
5 years ago (2015-12-21 13:23:50 UTC) #1
Yang
On 2015/12/21 13:23:50, Yang wrote: currently blocked on https://bugs.chromium.org/p/v8/issues/detail?id=4636
5 years ago (2015-12-21 13:24:16 UTC) #2
Yang
On 2015/12/21 13:24:16, Yang wrote: > On 2015/12/21 13:23:50, Yang wrote: > > currently blocked ...
5 years ago (2015-12-21 20:19:27 UTC) #6
caitp (gmail)
On 2015/12/21 20:19:27, Yang wrote: > On 2015/12/21 13:24:16, Yang wrote: > > On 2015/12/21 ...
5 years ago (2015-12-21 20:25:13 UTC) #7
Yang
On 2015/12/21 20:25:13, caitp wrote: > On 2015/12/21 20:19:27, Yang wrote: > > On 2015/12/21 ...
5 years ago (2015-12-21 20:30:05 UTC) #8
Dan Ehrenberg
lgtm
5 years ago (2015-12-21 20:45:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533313002/1
5 years ago (2015-12-22 07:44:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533313002/20001
5 years ago (2015-12-22 08:02:14 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-22 08:20:51 UTC) #17
commit-bot: I haz the power
5 years ago (2015-12-22 08:21:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/831b7ee3aa966a2920f3950a73c981dfe37a1c69
Cr-Commit-Position: refs/heads/master@{#33000}

Powered by Google App Engine
This is Rietveld 408576698