Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: src/parsing/pattern-rewriter.cc

Issue 1533313002: [debugger] step on every assignment in a destructuring assignment. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: extend test case Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/debug-step-destructuring-assignment.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/pattern-rewriter.cc
diff --git a/src/parsing/pattern-rewriter.cc b/src/parsing/pattern-rewriter.cc
index ead3081f9e90178f99e85099f0b42f953449a87a..a1b060031bfde40ce06c575a47bafddd515d9bb0 100644
--- a/src/parsing/pattern-rewriter.cc
+++ b/src/parsing/pattern-rewriter.cc
@@ -117,7 +117,7 @@ void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) {
Assignment* assignment = factory()->NewAssignment(
Token::ASSIGN, pattern, value, pattern->position());
block_->statements()->Add(
- factory()->NewExpressionStatement(assignment, RelocInfo::kNoPosition),
+ factory()->NewExpressionStatement(assignment, pattern->position()),
zone());
return;
}
« no previous file with comments | « no previous file | test/mjsunit/harmony/debug-step-destructuring-assignment.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698