Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1533163002:
Revert of Invalidate scrolling contents on scrolling contents layer only (Closed)
|
Created:
5 years ago by Xianzhu Modified:
5 years ago Reviewers:
chrishtr CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ )
Reason for revert:
The patch caused under-invalidation of some changed content display items
painting themselves on the main layer.
The patch was needed by synchronized painting in paint-invalidation-
during-paint mode. Now we plan to implement the mode in spv2 only which
doesn't have the main layer/contents layer problem so doesn't need the
patch.
Original issue's description:
> Invalidate scrolling contents on scrolling contents layer only
>
> This is required for synchronized painting to avoid assertion failure
> caused by extra invalidation on the scrolling container layer (which has
> finished painting) when we paint the scrolling contents layer.
>
> BUG=536999
>
> Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60
> Cr-Commit-Position: refs/heads/master@{#354589}
TBR=chrishtr@chromium.org
BUG=567875
Committed: https://crrev.com/a2ffd5fdd3acc5c829dca755e5088a330bf99db6
Cr-Commit-Position: refs/heads/master@{#366255}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : #
Messages
Total messages: 29 (16 generated)
Created Revert of Invalidate scrolling contents on scrolling contents layer only
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/1
The CQ bit was unchecked by wangxianzhu@chromium.org
Description was changed from ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation-during-paint mode. Now we plan to implement the mode in slimming paint v2 only which doesn't have the main layer/contents layer problem. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536999 ========== to ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation-during-paint mode. Now we plan to implement the mode in slimming paint v2 only which doesn't have the main layer/contents layer problem. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=536999 ==========
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
Description was changed from ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation-during-paint mode. Now we plan to implement the mode in slimming paint v2 only which doesn't have the main layer/contents layer problem. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=536999 ========== to ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation-during-paint mode. Now we plan to implement the mode in slimming paint v2 only which doesn't have the main layer/contents layer problem. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/130001
Description was changed from ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation-during-paint mode. Now we plan to implement the mode in slimming paint v2 only which doesn't have the main layer/contents layer problem. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ========== to ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation- during-paint mode. Now we plan to implement the mode in spv2 only which doesn't have the main layer/contents layer problem so doesn't need the patch. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/130001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/130001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/130001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533163002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533163002/150001
Message was sent while issue was closed.
Description was changed from ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation- during-paint mode. Now we plan to implement the mode in spv2 only which doesn't have the main layer/contents layer problem so doesn't need the patch. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ========== to ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation- during-paint mode. Now we plan to implement the mode in spv2 only which doesn't have the main layer/contents layer problem so doesn't need the patch. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:150001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation- during-paint mode. Now we plan to implement the mode in spv2 only which doesn't have the main layer/contents layer problem so doesn't need the patch. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 ========== to ========== Revert of Invalidate scrolling contents on scrolling contents layer only (patchset #5 id:70001 of https://codereview.chromium.org/1408913002/ ) Reason for revert: The patch caused under-invalidation of some changed content display items painting themselves on the main layer. The patch was needed by synchronized painting in paint-invalidation- during-paint mode. Now we plan to implement the mode in spv2 only which doesn't have the main layer/contents layer problem so doesn't need the patch. Original issue's description: > Invalidate scrolling contents on scrolling contents layer only > > This is required for synchronized painting to avoid assertion failure > caused by extra invalidation on the scrolling container layer (which has > finished painting) when we paint the scrolling contents layer. > > BUG=536999 > > Committed: https://crrev.com/933aa408647976a45828676e6477fa5059d04e60 > Cr-Commit-Position: refs/heads/master@{#354589} TBR=chrishtr@chromium.org BUG=567875 Committed: https://crrev.com/a2ffd5fdd3acc5c829dca755e5088a330bf99db6 Cr-Commit-Position: refs/heads/master@{#366255} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a2ffd5fdd3acc5c829dca755e5088a330bf99db6 Cr-Commit-Position: refs/heads/master@{#366255} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
