Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1533163002: Revert of Invalidate scrolling contents on scrolling contents layer only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 395 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 { 406 {
407 if (layer()->groupedMapping()) { 407 if (layer()->groupedMapping()) {
408 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) { 408 if (GraphicsLayer* squashingLayer = layer()->groupedMapping()->squashing Layer()) {
409 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account. 409 // Note: the subpixel accumulation of layer() does not need to be ad ded here. It is already taken into account.
410 IntRect paintInvalidationRectOnSquashingLayer; 410 IntRect paintInvalidationRectOnSquashingLayer;
411 if (paintInvalidationRect) 411 if (paintInvalidationRect)
412 paintInvalidationRectOnSquashingLayer = enclosingIntRect(*paintI nvalidationRect); 412 paintInvalidationRectOnSquashingLayer = enclosingIntRect(*paintI nvalidationRect);
413 squashingLayer->invalidateDisplayItemClient(displayItemClient, inval idationReason, paintInvalidationRect ? &paintInvalidationRectOnSquashingLayer : nullptr); 413 squashingLayer->invalidateDisplayItemClient(displayItemClient, inval idationReason, paintInvalidationRect ? &paintInvalidationRectOnSquashingLayer : nullptr);
414 } 414 }
415 } else if (CompositedLayerMapping* compositedLayerMapping = layer()->composi tedLayerMapping()) { 415 } else if (CompositedLayerMapping* compositedLayerMapping = layer()->composi tedLayerMapping()) {
416 if (this != &displayItemClient && isBox() && toLayoutBox(this)->usesComp ositedScrolling()) { 416 compositedLayerMapping->invalidateDisplayItemClient(displayItemClient, i nvalidationReason, paintInvalidationRect);
417 // This paint invalidation container is using composited scrolling, and we are invalidating a scrolling content,
418 // so we should invalidate on the scrolling contents layer only.
419 compositedLayerMapping->invalidateDisplayItemClientOnScrollingConten tsLayer(displayItemClient, invalidationReason, paintInvalidationRect);
420 } else {
421 compositedLayerMapping->invalidateDisplayItemClient(displayItemClien t, invalidationReason, paintInvalidationRect);
422 }
423 } 417 }
424 } 418 }
425 419
426 void LayoutBoxModelObject::addOutlineRectsForNormalChildren(Vector<LayoutRect>& rects, const LayoutPoint& additionalOffset, IncludeBlockVisualOverflowOrNot incl udeBlockOverflows) const 420 void LayoutBoxModelObject::addOutlineRectsForNormalChildren(Vector<LayoutRect>& rects, const LayoutPoint& additionalOffset, IncludeBlockVisualOverflowOrNot incl udeBlockOverflows) const
427 { 421 {
428 for (LayoutObject* child = slowFirstChild(); child; child = child->nextSibli ng()) { 422 for (LayoutObject* child = slowFirstChild(); child; child = child->nextSibli ng()) {
429 // Outlines of out-of-flow positioned descendants are handled in LayoutB lock::addOutlineRects(). 423 // Outlines of out-of-flow positioned descendants are handled in LayoutB lock::addOutlineRects().
430 if (child->isOutOfFlowPositioned()) 424 if (child->isOutOfFlowPositioned())
431 continue; 425 continue;
432 426
(...skipping 638 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 if (rootElementStyle->hasBackground()) 1065 if (rootElementStyle->hasBackground())
1072 return false; 1066 return false;
1073 1067
1074 if (node() != document().firstBodyElement()) 1068 if (node() != document().firstBodyElement())
1075 return false; 1069 return false;
1076 1070
1077 return true; 1071 return true;
1078 } 1072 }
1079 1073
1080 } // namespace blink 1074 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698