Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1533123002: Fix visibility of flip icon for camera images (Closed)

Created:
5 years ago by stevenjb
Modified:
5 years ago
Reviewers:
achuithb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix visibility of flip icon for camera images We eliminated the flip transitions which were buggy, we need to also remove the transition related code for the flip button. BUG=560721 Committed: https://crrev.com/3a8c5aaefde228e12a37c8bab0283a95dc2c2258 Cr-Commit-Position: refs/heads/master@{#366418}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M chrome/browser/resources/options/chromeos/change_picture_options.css View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/resources/options/chromeos/change_picture_options.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stevenjb
We probably also need to do something similar for login / oobe, along with something ...
5 years ago (2015-12-18 20:03:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533123002/20001
5 years ago (2015-12-20 15:07:46 UTC) #5
achuithb
lgtm
5 years ago (2015-12-20 15:09:57 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-20 15:51:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533123002/20001
5 years ago (2015-12-21 17:37:26 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-21 18:18:33 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-21 18:19:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a8c5aaefde228e12a37c8bab0283a95dc2c2258
Cr-Commit-Position: refs/heads/master@{#366418}

Powered by Google App Engine
This is Rietveld 408576698