Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1533083003:
Fix the android symbolization instructions. (Closed)
|
Created:
5 years ago by Jeffrey Yasskin Modified:
5 years ago Reviewers:
agrieve CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix the android symbolization instructions for gn.
out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped.
Committed: https://crrev.com/c1c76ff0f3c099a938f1d7d5d0f2639b9b42e7e3
Cr-Commit-Position: refs/heads/master@{#366175}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Suggest $CHROMIUM_OUTPUT_DIR instead. #Messages
Total messages: 17 (8 generated)
jyasskin@chromium.org changed reviewers: + agrieve@chromium.org
PTAL.
The CQ bit was checked by jyasskin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533083003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks for fixing this and for filing Android ergonomics bugs. https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:156: `--chrome-symbols-dir=out_path` to the script as well. I think you should give explicit examples for both GYP and GN, since with --chrome-symbols-dir, you need to pass it out/Debug/lib on GYP and out/Debug/lib.unstripped for GN. Alternatively, it's might be better to do promote the use of: CHROMIUM_OUTPUT_DIR=path/to/out/Debug third_party/android_platform/development/scripts/stack since then the script will look for both lib and lib.unstripped within there.
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... File docs/android_test_instructions.md (right): https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... docs/android_test_instructions.md:156: `--chrome-symbols-dir=out_path` to the script as well. On 2015/12/18 20:19:33, agrieve wrote: > I think you should give explicit examples for both GYP and GN, since with > --chrome-symbols-dir, you need to pass it out/Debug/lib on GYP and > out/Debug/lib.unstripped for GN. > > Alternatively, it's might be better to do promote the use of: > CHROMIUM_OUTPUT_DIR=path/to/out/Debug > third_party/android_platform/development/scripts/stack > > since then the script will look for both lib and lib.unstripped within there. How's this?
Description was changed from ========== Fix the android symbolization instructions. out/Debug/lib doesn't exist, and gn doesn't always use out/Debug or out/Release. ========== to ========== Fix the android symbolization instructions for gn. out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped. ==========
On 2015/12/18 21:00:06, Jeffrey Yasskin wrote: > https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... > File docs/android_test_instructions.md (right): > > https://codereview.chromium.org/1533083003/diff/1/docs/android_test_instructi... > docs/android_test_instructions.md:156: `--chrome-symbols-dir=out_path` to the > script as well. > On 2015/12/18 20:19:33, agrieve wrote: > > I think you should give explicit examples for both GYP and GN, since with > > --chrome-symbols-dir, you need to pass it out/Debug/lib on GYP and > > out/Debug/lib.unstripped for GN. > > > > Alternatively, it's might be better to do promote the use of: > > CHROMIUM_OUTPUT_DIR=path/to/out/Debug > > third_party/android_platform/development/scripts/stack > > > > since then the script will look for both lib and lib.unstripped within there. > > How's this? lgtm. thanks!
The CQ bit was checked by jyasskin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533083003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533083003/40001
Message was sent while issue was closed.
Description was changed from ========== Fix the android symbolization instructions for gn. out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped. ========== to ========== Fix the android symbolization instructions for gn. out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix the android symbolization instructions for gn. out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped. ========== to ========== Fix the android symbolization instructions for gn. out/Debug/lib doesn't exist on gn, so it's better to use $CHROMIUM_OUTPUT_DIR to let the script search both lib and lib.unstripped. Committed: https://crrev.com/c1c76ff0f3c099a938f1d7d5d0f2639b9b42e7e3 Cr-Commit-Position: refs/heads/master@{#366175} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/c1c76ff0f3c099a938f1d7d5d0f2639b9b42e7e3 Cr-Commit-Position: refs/heads/master@{#366175} |
