Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: docs/android_test_instructions.md

Issue 1533083003: Fix the android symbolization instructions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Suggest $CHROMIUM_OUTPUT_DIR instead. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/android_test_instructions.md
diff --git a/docs/android_test_instructions.md b/docs/android_test_instructions.md
index 008c7cca34acc05870364fba128c9cfb11cd830f..616a970b63b5ce8dc664a719643d69010987f6d3 100644
--- a/docs/android_test_instructions.md
+++ b/docs/android_test_instructions.md
@@ -150,10 +150,26 @@ tune2fs -e continue android_emulator_sdk/sdk/system-images/android-23/x86/userda
## Symbolizing Crashes
Crash stacks are logged and can be viewed using adb logcat. To symbolize the
-traces, pipe the output through
-`third_party/android_platform/development/scripts/stack`. If you build in an
-output directory other than "out", pass
-`--chrome-symbols-dir=out_directory/{Debug,Release}/lib` to the script as well.
+traces, define `CHROMIUM_OUTPUT_DIR=$OUTDIR` where `$OUTDIR` is the argument you
+pass to `ninja -C`, and pipe the output through
+`third_party/android_platform/development/scripts/stack`. If
+`$CHROMIUM_OUTPUT_DIR` is unset, the script will search `out/Debug` and
+`out/Release`. For example:
+
+```shell
+# If you build with
+ninja -C out/Debug chrome_public_test_apk
+# You can run:
+adb logcat -d | third_party/android_platform/development/scripts/stack
+
+# If you build with
+ninja -C out/android chrome_public_test_apk
+# You can run:
+adb logcat -d | CHROMIUM_OUTPUT_DIR=out/android third_party/android_platform/development/scripts/stack
+# or
+export CHROMIUM_OUTPUT_DIR=out/android
+adb logcat -d | third_party/android_platform/development/scripts/stack
+```
## JUnit tests
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698