Issue 1533023002: - Make sure to prepare all threads for GC.

Issue 1533023002: - Make sure to prepare all threads for GC. (Closed)

Created:
5 years ago by Ivan Posva

Modified:
5 years ago

Reviewers:
srdjan, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

- Make sure to prepare all threads for GC. BUG= R=asiva@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/e47ac24c795cd3aebe3248c622dca5864a965c3e

Patch Set 2 : Address review comments. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
M	runtime/vm/gc_marker.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/scavenger.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/thread.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1	2 chunks	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/thread_registry.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/thread_registry.cc	View		3 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

lgtm https://codereview.chromium.org/1533023002/diff/1/runtime/vm/thread.cc File runtime/vm/thread.cc (right): https://codereview.chromium.org/1533023002/diff/1/runtime/vm/thread.cc#newcode239 runtime/vm/thread.cc:239: void Thread::PrepareForGC() { ASSERT(isolate()->thread_registry()->AtSafepoint());

5 years ago (2015-12-18 01:05:02 UTC) #3

Ivan Posva

Committed patchset #2 (id:20001) manually as e47ac24c795cd3aebe3248c622dca5864a965c3e (presubmit successful).

5 years ago (2015-12-18 03:59:20 UTC) #6

Ivan Posva

5 years ago (2015-12-18 03:59:50 UTC) #7

Message was sent while issue was closed.

Thanks!

-Ivan

https://codereview.chromium.org/1533023002/diff/1/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/1533023002/diff/1/runtime/vm/thread.cc#newcod...
runtime/vm/thread.cc:239: void Thread::PrepareForGC() {
On 2015/12/18 01:05:02, siva wrote:
> ASSERT(isolate()->thread_registry()->AtSafepoint());

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages