runtime/vm/thread_test.cc - Issue 1533023002: - Make sure to prepare all threads for GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_test.cc

Issue 1533023002: - Make sure to prepare all threads for GC. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/thread_test.cc

diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc

index ec998f8980d16df6d998e1b3045f6a8a540c7d4c..33ce9f83db89e6db6212ac18e146925e1894fbac 100644

--- a/runtime/vm/thread_test.cc

+++ b/runtime/vm/thread_test.cc

@@ -570,7 +570,7 @@ TEST_CASE(HelperAllocAndGC) {

// TODO(koda): Currently, the GC only does this for the current thread, (i.e,

// the helper, in this test), but it should be done for all *threads*

// while reaching a safepoint.

- Thread::PrepareForGC();

+ isolate->thread_registry()->PrepareForGC();

Dart::thread_pool()->Run(new AllocAndGCTask(isolate, &done_monitor, &done));

{

while (true) {

« no previous file with comments | « runtime/vm/thread_registry.cc ('k') | no next file » | no next file with comments »