Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1533003002: Don't set -fvisibility=hidden for iOS Debug in GYP. (Closed)

Created:
5 years ago by baxley
Modified:
5 years ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, sdefresne
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set -fvisibility=hidden for iOS Debug in GYP. Remove -fvisibility=hidden for Debug configuration on iOS at the top level (common.gypi), so we don't remove symbols from dependencies. BUG=569073 Committed: https://crrev.com/b17fbf8f6b05bd868b1555bcbda50c9dfad1946f Cr-Commit-Position: refs/heads/master@{#366106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M build/common.gypi View 2 chunks +27 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
baxley
There are a few unresolved issues on the GN portion of this change in: https://codereview.chromium.org/1514423003/ ...
5 years ago (2015-12-17 22:55:20 UTC) #2
Dirk Pranke
lgtm. I'm perfectly fine with these being two different changes.
5 years ago (2015-12-18 03:04:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1533003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1533003002/1
5 years ago (2015-12-18 14:21:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 16:25:55 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b17fbf8f6b05bd868b1555bcbda50c9dfad1946f Cr-Commit-Position: refs/heads/master@{#366106}
5 years ago (2015-12-18 16:26:46 UTC) #9
baxley
5 years ago (2015-12-18 16:45:54 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1538573005/ by baxley@chromium.org.

The reason for reverting is: fails compile on xcodebuild + device.

Powered by Google App Engine
This is Rietveld 408576698