Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: build/common.gypi

Issue 1533003002: Don't set -fvisibility=hidden for iOS Debug in GYP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5063 matching lines...) Expand 10 before | Expand all | Expand 10 after
5074 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime 5074 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime
5075 'COPY_PHASE_STRIP': 'NO', 5075 'COPY_PHASE_STRIP': 'NO',
5076 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99 5076 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99
5077 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks 5077 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks
5078 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions 5078 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
5079 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti 5079 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti
5080 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings 5080 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings
5081 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden 5081 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
5082 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 5082 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
5083 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 5083 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
5084 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5085 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 5084 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
5086 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 5085 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
5087 'GCC_VERSION': '4.2', 5086 'GCC_VERSION': '4.2',
5088 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 5087 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
5089 'USE_HEADERMAP': 'NO', 5088 'USE_HEADERMAP': 'NO',
5090 'WARNING_CFLAGS': [ 5089 'WARNING_CFLAGS': [
5091 '-Wall', 5090 '-Wall',
5092 '-Wextra', 5091 '-Wextra',
5093 # Don't warn about unused function parameters. 5092 # Don't warn about unused function parameters.
5094 '-Wno-unused-parameter', 5093 '-Wno-unused-parameter',
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
5136 'OTHER_CFLAGS': [ 5135 'OTHER_CFLAGS': [
5137 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)', 5136 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)',
5138 ], 5137 ],
5139 }], 5138 }],
5140 ['clang==1 and "<(GENERATOR)"=="ninja"', { 5139 ['clang==1 and "<(GENERATOR)"=="ninja"', {
5141 'OTHER_CFLAGS': [ 5140 'OTHER_CFLAGS': [
5142 # See http://crbug.com/110262 5141 # See http://crbug.com/110262
5143 '-fcolor-diagnostics', 5142 '-fcolor-diagnostics',
5144 ], 5143 ],
5145 }], 5144 }],
5146 ['OS=="ios" and target_subarch!="arm32" and \ 5145 ['OS=="ios"', {
5147 "<(GENERATOR)"=="xcode"', { 5146 'configurations': {
5148 'OTHER_CFLAGS': [ 5147 'Debug': {
5149 # TODO(ios): when building Chrome for iOS on 64-bit platform 5148 # XCTests inject a dynamic library into the application. If
5150 # with Xcode, the -Wshorted-64-to-32 warning is automatically 5149 # fvisibility is set to hidden, then some symbols needed by
5151 # enabled. This cause failures when compiling protobuf code, 5150 # XCTests are not available. Disable this setting for
5152 # so disable the warning. http://crbug.com/359107 5151 # Debug configuration.
5153 '-Wno-shorten-64-to-32', 5152 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
5153 },
5154 'Release': {
5155 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5156 },
5157 },
5158 'conditions': [
5159 ['target_subarch!="arm32" and "<(GENERATOR)"=="xcode"', {
5160 'OTHER_CFLAGS': [
5161 # TODO(ios): when building Chrome for iOS on 64-bit
5162 # platform with Xcode, the -Wshorted-64-to-32 warning is
5163 # automatically enabled. This causes failures when
5164 # compiling protobuf code, so disable the warning.
5165 # http://crbug.com/359107
5166 '-Wno-shorten-64-to-32',
5167 ],
5168 }],
5154 ], 5169 ],
5155 }], 5170 }],
5171 ['OS=="mac"', {
5172 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5173 }],
5156 ], 5174 ],
5157 }, 5175 },
5158 'conditions': [ 5176 'conditions': [
5159 ['clang==1', { 5177 ['clang==1', {
5160 'variables': { 5178 'variables': {
5161 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin', 5179 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
5162 }, 5180 },
5163 }], 5181 }],
5164 ['asan==1', { 5182 ['asan==1', {
5165 'xcode_settings': { 5183 'xcode_settings': {
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
6417 # settings in target dicts. SYMROOT is a special case, because many other 6435 # settings in target dicts. SYMROOT is a special case, because many other
6418 # Xcode variables depend on it, including variables such as 6436 # Xcode variables depend on it, including variables such as
6419 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6437 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6420 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6438 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6421 # files to appear (when present) in the UI as actual files and not red 6439 # files to appear (when present) in the UI as actual files and not red
6422 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6440 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6423 # and therefore SYMROOT, needs to be set at the project level. 6441 # and therefore SYMROOT, needs to be set at the project level.
6424 'SYMROOT': '<(DEPTH)/xcodebuild', 6442 'SYMROOT': '<(DEPTH)/xcodebuild',
6425 }, 6443 },
6426 } 6444 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698