Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1532973002: Add support for (de)serializing LayerSelectionBound. (Closed)

Created:
5 years ago by nyquist
Modified:
5 years ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for (de)serializing LayerSelectionBound. As part of serializing cc::LayerTreeHost, we also need to serialize the cc::LayerTreeBounds. BUG=561210 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9de8ad81c88e8f82afb072204852d4cd61fa4814 Cr-Commit-Position: refs/heads/master@{#366155}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made operator members #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -14 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/input/layer_selection_bound.h View 1 2 chunks +10 lines, -3 lines 0 comments Download
M cc/input/layer_selection_bound.cc View 1 2 chunks +60 lines, -7 lines 0 comments Download
A cc/input/layer_selection_bound_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M cc/proto/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + cc/proto/layer_selection_bound.proto View 1 chunk +13 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532973002/1
5 years ago (2015-12-17 21:04:53 UTC) #3
nyquist
vmpstr: PTAL
5 years ago (2015-12-17 21:34:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-17 23:37:24 UTC) #7
vmpstr
lgtm https://codereview.chromium.org/1532973002/diff/1/cc/input/layer_selection_bound.h File cc/input/layer_selection_bound.h (right): https://codereview.chromium.org/1532973002/diff/1/cc/input/layer_selection_bound.h#newcode33 cc/input/layer_selection_bound.h:33: CC_EXPORT bool operator==(const LayerSelectionBound& lhs, While here, did ...
5 years ago (2015-12-18 07:46:02 UTC) #8
nyquist
All done. https://codereview.chromium.org/1532973002/diff/1/cc/input/layer_selection_bound.h File cc/input/layer_selection_bound.h (right): https://codereview.chromium.org/1532973002/diff/1/cc/input/layer_selection_bound.h#newcode33 cc/input/layer_selection_bound.h:33: CC_EXPORT bool operator==(const LayerSelectionBound& lhs, On 2015/12/18 ...
5 years ago (2015-12-18 18:53:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532973002/20001
5 years ago (2015-12-18 18:54:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 20:09:13 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 20:10:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9de8ad81c88e8f82afb072204852d4cd61fa4814
Cr-Commit-Position: refs/heads/master@{#366155}

Powered by Google App Engine
This is Rietveld 408576698