Add support for (de)serializing LayerSelection.

Add support for (de)serializing LayerSelection.

As part of serializing cc::LayerTreeHost, we also need to
serialize the Selection<LayerSelectionBound>, which is
typedef'ed to LayerSelection.

We only support this type of the templated Selection for now,
so the code lives together with the LayerSelectionBound.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/be6c29c514beca0a3d18158d4fbef28b26d6fa53
Cr-Commit-Position: refs/heads/master@{#366202}

[nyquist, 2015-12-17 21:33:09]

Description was changed from

==========
Add support for (de)serializing LayerSelection.

As part of serializing cc::LayerTreeHost, we also need to
serialize the Selection<LayerSelectionBound>, which is
typedef'ed to LayerSelection.

We only support this type of the templated Selection for now,
so the code lives together with the LayerSelectionBound.

BUG=561210
==========

to

==========
Add support for (de)serializing LayerSelection.

As part of serializing cc::LayerTreeHost, we also need to
serialize the Selection<LayerSelectionBound>, which is
typedef'ed to LayerSelection.

We only support this type of the templated Selection for now,
so the code lives together with the LayerSelectionBound.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[nyquist, 2015-12-17 21:33:41]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2015-12-17 21:34:10]

nyquist@chromium.org changed reviewers:
+ vmpstr@chromium.org

[nyquist, 2015-12-17 21:34:11]

vmpstr: PTAL

[commit-bot: I haz the power, 2015-12-17 21:37:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531413002/1

[commit-bot: I haz the power, 2015-12-17 23:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 23:46:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2015-12-18 07:50:02]

lgtm with nits

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
File cc/input/layer_selection_bound_unittest.cc (right):

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:37: void
VerifySerializeAndDeserializeLayerSelectionProto(
Move this after the other function above please. I kind of prefer having
functions followed by tests... But this isn't a strong suggestion, so if you
prefer this way it's fine too.

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:51: start.layer_id = 42;
blank after this line please

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:56: end.layer_id = 24;
blank after this line please

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:61:
selection.is_empty_text_form_control = true;
blank after this line please

[nyquist, 2015-12-18 18:54:35]

All done.

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
File cc/input/layer_selection_bound_unittest.cc (right):

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:37: void
VerifySerializeAndDeserializeLayerSelectionProto(
On 2015/12/18 07:50:02, vmpstr wrote:
> Move this after the other function above please. I kind of prefer having
> functions followed by tests... But this isn't a strong suggestion, so if you
> prefer this way it's fine too.

Done.

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:51: start.layer_id = 42;
On 2015/12/18 07:50:02, vmpstr wrote:
> blank after this line please

Done.

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:56: end.layer_id = 24;
On 2015/12/18 07:50:02, vmpstr wrote:
> blank after this line please

Done.

https://codereview.chromium.org/1531413002/diff/1/cc/input/layer_selection_bo...
cc/input/layer_selection_bound_unittest.cc:61:
selection.is_empty_text_form_control = true;
On 2015/12/18 07:50:02, vmpstr wrote:
> blank after this line please

Done.

[nyquist, 2015-12-18 22:12:54]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2015-12-18 22:12:55]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/1531413002/#ps20001
(title: "Addressed nits from vmpstr")

[commit-bot: I haz the power, 2015-12-18 22:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531413002/20001

[commit-bot: I haz the power, 2015-12-18 23:18:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-18 23:19:14]

Description was changed from

==========
Add support for (de)serializing LayerSelection.

As part of serializing cc::LayerTreeHost, we also need to
serialize the Selection<LayerSelectionBound>, which is
typedef'ed to LayerSelection.

We only support this type of the templated Selection for now,
so the code lives together with the LayerSelectionBound.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add support for (de)serializing LayerSelection.

As part of serializing cc::LayerTreeHost, we also need to
serialize the Selection<LayerSelectionBound>, which is
typedef'ed to LayerSelection.

We only support this type of the templated Selection for now,
so the code lives together with the LayerSelectionBound.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/be6c29c514beca0a3d18158d4fbef28b26d6fa53
Cr-Commit-Position: refs/heads/master@{#366202}
==========

[commit-bot: I haz the power, 2015-12-18 23:19:15]

Patchset 2 (id:??) landed as
https://crrev.com/be6c29c514beca0a3d18158d4fbef28b26d6fa53
Cr-Commit-Position: refs/heads/master@{#366202}