Issue 1532793003: Use correct width for narrow panel in Reader Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1532793003: Use correct width for narrow panel in Reader Mode (Closed)

Created:
5 years ago by mdjones

Modified:
5 years ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2564

Target Ref:
refs/pending/branch-heads/2564

Project:
chromium

Visibility:
Public.

Use correct width for narrow panel in Reader Mode The ContentViewClient responsible for setting the width of the panel content in Contextual Search is now set is the OverlayPanel. BUG=568616, 560130 Review URL: https://codereview.chromium.org/1514603007 Cr-Commit-Position: refs/heads/master@{#365420} (cherry picked from commit 37c3add1876e61586b99b2d63fbe8159c2717a85) Committed: https://chromium.googlesource.com/chromium/src/+/53396d3d380851f27f0640c407ff5c61f3544345

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -28 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java	View		3 chunks	+27 lines, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java	View		3 chunks	+2 lines, -27 lines	0 comments	Download

Total messages: 2 (1 generated)

mdjones

5 years ago (2015-12-18 00:59:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
53396d3d380851f27f0640c407ff5c61f3544345.