Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1514603007: Use correct width for narrow panel in Reader Mode (Closed)

Created:
5 years ago by mdjones
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct width for narrow panel in Reader Mode The ContentViewClient responsible for setting the width of the panel content in Contextual Search is now set is the OverlayPanel. BUG=568616, 560130 Committed: https://crrev.com/37c3add1876e61586b99b2d63fbe8159c2717a85 Cr-Commit-Position: refs/heads/master@{#365420}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 1 3 chunks +27 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanel.java View 3 chunks +2 lines, -27 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
mdjones
PTAL
5 years ago (2015-12-11 01:34:42 UTC) #2
pedro (no code reviews)
lgtm https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java (right): https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java#newcode290 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:290: if (!isFullscreenSizePanel()) { We might as well always ...
5 years ago (2015-12-15 21:50:33 UTC) #6
mdjones
https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java (right): https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java#newcode290 chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:290: if (!isFullscreenSizePanel()) { On 2015/12/15 21:50:33, pedrosimonetti wrote: > ...
5 years ago (2015-12-15 23:28:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514603007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514603007/20001
5 years ago (2015-12-15 23:30:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/111212)
5 years ago (2015-12-16 01:22:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514603007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514603007/20001
5 years ago (2015-12-16 01:27:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 03:38:58 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-16 03:39:56 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37c3add1876e61586b99b2d63fbe8159c2717a85
Cr-Commit-Position: refs/heads/master@{#365420}

Powered by Google App Engine
This is Rietveld 408576698