Use correct width for narrow panel in Reader Mode

Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130
Committed: https://crrev.com/37c3add1876e61586b99b2d63fbe8159c2717a85
Cr-Commit-Position: refs/heads/master@{#365420}

[mdjones, 2015-12-11 01:34:42]

mdjones@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[mdjones, 2015-12-11 01:34:42]

PTAL

[mdjones, 2015-12-11 16:36:53]

Description was changed from

==========
Use correct with for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616
==========

to

==========
Use correct with for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616
==========

[mdjones, 2015-12-11 16:37:16]

Description was changed from

==========
Use correct with for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616
==========

to

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616
==========

[mdjones, 2015-12-11 19:34:44]

Description was changed from

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616
==========

to

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130
==========

[pedro (no code reviews), 2015-12-15 21:50:33]

lgtm

https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:290:
if (!isFullscreenSizePanel()) {
We might as well always set the client, since we will preserve the panel
position upon rotation now, which means "fullscreen panel" might toggle state
when you rotate the device.

[mdjones, 2015-12-15 23:28:29]

https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
(right):

https://codereview.chromium.org/1514603007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java:290:
if (!isFullscreenSizePanel()) {
On 2015/12/15 21:50:33, pedrosimonetti wrote:
> We might as well always set the client, since we will preserve the panel
> position upon rotation now, which means "fullscreen panel" might toggle state
> when you rotate the device.

Done.

[mdjones, 2015-12-15 23:28:39]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-12-15 23:28:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1514603007/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2015-12-15 23:30:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514603007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514603007/20001

[commit-bot: I haz the power, 2015-12-16 01:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 01:22:03]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[mdjones, 2015-12-16 01:23:08]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2015-12-16 01:27:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514603007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514603007/20001

[commit-bot: I haz the power, 2015-12-16 03:38:58]

Description was changed from

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130
==========

to

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130
==========

[commit-bot: I haz the power, 2015-12-16 03:38:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 03:39:55]

Description was changed from

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130
==========

to

==========
Use correct width for narrow panel in Reader Mode

The ContentViewClient responsible for setting the width of the
panel content in Contextual Search is now set is the OverlayPanel.

BUG=568616, 560130

Committed: https://crrev.com/37c3add1876e61586b99b2d63fbe8159c2717a85
Cr-Commit-Position: refs/heads/master@{#365420}
==========

[commit-bot: I haz the power, 2015-12-16 03:39:56]

Patchset 2 (id:??) landed as
https://crrev.com/37c3add1876e61586b99b2d63fbe8159c2717a85
Cr-Commit-Position: refs/heads/master@{#365420}