Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1532773002: Revert of Use SequenceChecker to allow Timer to run in SequencedWorkerPool (Closed)

Created:
5 years ago by jsbell
Modified:
5 years ago
Reviewers:
danakj, gab, Nico
CC:
chromium-reviews, chirantan+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use SequenceChecker to allow Timer to run in SequencedWorkerPool (patchset #6 id:100001 of https://codereview.chromium.org/1433373003/ ) Reason for revert: TSAN failures in the test. Won't have a chance to debug for a few days, so reverting for now. Sample failure: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/14813 Original issue's description: > Use SequenceChecker to allow Timer to run in SequencedWorkerPool > > Timer was explicitly ensuring single-threaded usage by tracking the > thread used for scheduling tasks. Generalize that to ensure sequenced > task runner affinity via SequenceChecker, so it can be used by > SequencedWorkerPool threads. > > BUG=552633 > > Committed: https://crrev.com/ffa30fe7f5ec8b13c9e41d41d828e4fb8e67110b > Cr-Commit-Position: refs/heads/master@{#365568} TBR=gab@chromium.org,danakj@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=552633 Committed: https://crrev.com/763cd405e2c86701be08e3e64a24df6a2e316e7f Cr-Commit-Position: refs/heads/master@{#365683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -259 lines) Patch
M base/timer/timer.h View 7 chunks +20 lines, -31 lines 0 comments Download
M base/timer/timer.cc View 6 chunks +22 lines, -24 lines 0 comments Download
M base/timer/timer_unittest.cc View 3 chunks +2 lines, -204 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
Created Revert of Use SequenceChecker to allow Timer to run in SequencedWorkerPool
5 years ago (2015-12-17 00:04:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532773002/1
5 years ago (2015-12-17 00:06:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532773002/1
5 years ago (2015-12-17 00:11:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532773002/1
5 years ago (2015-12-17 00:33:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 00:38:37 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-17 00:39:38 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763cd405e2c86701be08e3e64a24df6a2e316e7f
Cr-Commit-Position: refs/heads/master@{#365683}

Powered by Google App Engine
This is Rietveld 408576698