Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1532723005: [proxies] Fix Object.prototype.hasOwnProperty (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Fix Object.prototype.hasOwnProperty It must call the 'getOwnPropertyDescriptor' trap, not the 'has' trap. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:1543 LOG=n Committed: https://crrev.com/641cdd30676b4aeee056f4e1b4f0fe923a00e599 Cr-Commit-Position: refs/heads/master@{#32944}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -48 lines) Patch
M src/objects.h View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/objects-inl.h View 2 chunks +10 lines, -11 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies.js View 1 2 chunks +12 lines, -23 lines 0 comments Download
M test/mjsunit/harmony/proxies-has-own-property.js View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
neis
5 years ago (2015-12-17 10:00:36 UTC) #1
Jakob Kummerow
LGTM https://codereview.chromium.org/1532723005/diff/1/test/mjsunit/harmony/proxies.js File test/mjsunit/harmony/proxies.js (right): https://codereview.chromium.org/1532723005/diff/1/test/mjsunit/harmony/proxies.js#newcode977 test/mjsunit/harmony/proxies.js:977: has() { throw "never called" } nit: we ...
5 years ago (2015-12-17 11:43:48 UTC) #2
neis
5 years ago (2015-12-17 11:53:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1532723005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1532723005/20001
5 years ago (2015-12-17 11:53:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 12:12:09 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-17 12:12:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/641cdd30676b4aeee056f4e1b4f0fe923a00e599
Cr-Commit-Position: refs/heads/master@{#32944}

Powered by Google App Engine
This is Rietveld 408576698