Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: test/mjsunit/harmony/proxies-has-own-property.js

Issue 1532723005: [proxies] Fix Object.prototype.hasOwnProperty (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/harmony/proxies.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/proxies-has-own-property.js
diff --git a/test/mjsunit/harmony/proxies-has-own-property.js b/test/mjsunit/harmony/proxies-has-own-property.js
index 8e5a3ed57fa080b641a9513ccb14e39f33d7d866..1455d2b273d73b415d9649e04df2f768b4f7be4a 100644
--- a/test/mjsunit/harmony/proxies-has-own-property.js
+++ b/test/mjsunit/harmony/proxies-has-own-property.js
@@ -14,25 +14,25 @@ assertFalse(target.hasOwnProperty('b'));
assertFalse(proxy.hasOwnProperty('b'));
-handler.has = function() {
- return false;
-}
+handler.has = function() { assertUnreachable() }
+handler.getOwnPropertyDescriptor = function () {}
+
assertTrue(target.hasOwnProperty('a'));
assertFalse(proxy.hasOwnProperty('a'));
assertFalse(target.hasOwnProperty('b'));
assertFalse(proxy.hasOwnProperty('b'));
-handler.has = function() {
- return true;
-}
+
+handler.getOwnPropertyDescriptor = function() { return {configurable: true} }
+
assertTrue(target.hasOwnProperty('a'));
assertTrue(proxy.hasOwnProperty('a'));
assertFalse(target.hasOwnProperty('b'));
assertTrue(proxy.hasOwnProperty('b'));
-handler.has = function() {
- throw Error();
-}
+
+handler.getOwnPropertyDescriptor = function() { throw Error(); }
+
assertTrue(target.hasOwnProperty('a'));
assertThrows(function(){ proxy.hasOwnProperty('a') }, Error);
assertFalse(target.hasOwnProperty('b'));
« no previous file with comments | « test/mjsunit/harmony/proxies.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698