Issue 1532283002: Merge to XFA: Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1532283002: Merge to XFA: Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt (Closed)

Created:
5 years ago by Oliver Chang

Modified:
5 years ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt It looks like an key length of 0 was incorrectly assumed to denote an free entry. Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with empty keys being incorrectly overwritten. TBR=tsepez@chromium.org Original Review URL: https://codereview.chromium.org/1534953002 . (cherry picked from commit 391783579c5a8aad346b56903b51e6551600550b) Committed: https://pdfium.googlesource.com/pdfium/+/b6718d06db22252fa44117cc3be11430da7779f9

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -11 lines)			Patch
	M	core/src/fxcrt/fx_basic_maps.cpp	View		10 chunks	+18 lines, -11 lines	0 comments	Download

Total messages: 3 (1 generated)

Oliver Chang

5 years ago (2015-12-18 00:52:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b6718d06db22252fa44117cc3be11430da7779f9 (presubmit successful).