Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=tsepez@chromium.org, thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/391783579c5a8aad346b56903b51e6551600550b

[Oliver Chang, 2015-12-18 00:32:40]

Description was changed from

==========
Fix the sentinel value used in finding free slots in
CFX_CMapByteStringToPtr::SetAt

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
==========

to

==========
Fix the sentinel value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
==========

[Oliver Chang, 2015-12-18 00:33:29]

Description was changed from

==========
Fix the sentinel value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.
==========

to

==========
Fix the sentinel value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

[Oliver Chang, 2015-12-18 00:33:43]

ochang@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Oliver Chang, 2015-12-18 00:34:00]

Description was changed from

==========
Fix the sentinel value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

to

==========
Fix a sentinel length value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

[Oliver Chang, 2015-12-18 00:35:05]

Patchset #1 (id:1) has been deleted

[Oliver Chang, 2015-12-18 00:35:54]

ptal

[Oliver Chang, 2015-12-18 00:41:37]

Description was changed from

==========
Fix a sentinel length value used in in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

to

==========
Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

[Tom Sepez, 2015-12-18 00:42:26]

LGTM.  If you're feeling ambitious, this is one of those types that should just
die in favor of std::map someday.

[Oliver Chang, 2015-12-18 00:46:19]

On 2015/12/18 00:42:26, Tom Sepez wrote:
> LGTM.  If you're feeling ambitious, this is one of those types that should
just
> die in favor of std::map someday.

Sounds fun, might give that a shot one of these days.

[Oliver Chang, 2015-12-18 00:47:17]

Description was changed from

==========
Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=thestig@chromium.org,tsepez@chromium.org
==========

to

==========
Fix a sentinel length value used in CFX_CMapByteStringToPtr::SetAt

It looks like an key length of 0 was incorrectly assumed to
denote an free entry.

Fixes a memory leak in FPDFViewEmbeddertest.Crasher_451830 due to values with
empty keys being incorrectly overwritten.

R=tsepez@chromium.org, thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/391783579c5a8aad346b56903b51e6551600...
==========

[Oliver Chang, 2015-12-18 00:47:19]

Committed patchset #2 (id:40001) manually as
391783579c5a8aad346b56903b51e6551600550b (presubmit successful).