src/DartARM32/assembler_arm.h - Issue 1532233002: Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1532233002: Add VPUSH/VPOP instructions to the ARM32 integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove TODO that doesn't apply anymore. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.h

diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h

index bf6bc11aa39337d7a5e1fa66dd984ddaa09674e6..a2044058f1e8b18b7caa5f6c5351bf274a7e0c6a 100644

--- a/src/DartARM32/assembler_arm.h

+++ b/src/DartARM32/assembler_arm.h

@@ -1320,7 +1320,9 @@ class Assembler : public ValueObject {

#if 0

// Added the following missing operations:

- // ARM32::AssemblerARM::uxt() (uxtb and uxth).

+ // ARM32::AssemblerARM32::uxt() (uxtb and uxth).

+ // ARM32::AssemblerARM32::vpop()

+ // ARM32::AssemblerARM32::vpush()

#endif

DISALLOW_ALLOCATION();

« no previous file with comments | « no previous file | src/IceAssemblerARM32.h » ('j') | src/IceAssemblerARM32.cpp » ('J')