Issue 1532113002: Adds a --body_hex flag to quic_client_bin to allow POST message body to be specified as a hex strin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1532113002: Adds a --body_hex flag to quic_client_bin to allow POST message body to be specified as a hex strin… (Closed)

Created:
5 years ago by danzh1

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@110183495

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Adds a --body_hex flag to quic_client_bin to allow POST message body to be specified as a hex string, converted with a2b_hex before sending. e.g../quic_client_bin--body_hex="68656c6c6f2c20776f726c6421" This is helpful for gRPC-over-QUIC testing. n/a (toy quic client) Merge internal change: 110185550 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -7 lines)			Patch
	M	net/tools/quic/quic_client_bin.cc	View		6 chunks	+30 lines, -4 lines	2 comments	Download
	M	net/tools/quic/quic_simple_client_bin.cc	View		6 chunks	+29 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1531783002 Patch 20001

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

https://codereview.chromium.org/1532113002/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/1532113002/diff/1/net/tools/quic/quic_client_bin.cc#newcode124 net/tools/quic/quic_client_bin.cc:124: static bool DecodeHexString(const base::StringPiece& hex, std::string* bytes) { Instead, ...

5 years ago (2015-12-17 17:59:39 UTC) #2

Ryan Hamilton

5 years ago (2015-12-17 18:37:44 UTC) #3

lgtm

https://codereview.chromium.org/1532113002/diff/1/net/tools/quic/quic_client_...
File net/tools/quic/quic_client_bin.cc (right):

https://codereview.chromium.org/1532113002/diff/1/net/tools/quic/quic_client_...
net/tools/quic/quic_client_bin.cc:124: static bool DecodeHexString(const
base::StringPiece& hex, std::string* bytes) {
On 2015/12/17 17:59:39, Ryan Hamilton wrote:
> Instead, can you try base::HexStringToBytes from
> base/strings/string_number_conversions.h?

Whoops, this is already doing that, of course.

Expand Messages | Collapse Messages