Issue 1531783002: Turn on the trailers support flag in the toy QUIC client.

Issue 1531783002: Turn on the trailers support flag in the toy QUIC client. (Closed)

Created:
5 years ago by danzh1

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@110177994

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Turn on the trailers support flag in the toy QUIC client. n/a (quic toy client) Merge internal change: 110183495 R=rch@chromium.org BUG=

Patch Set 2 : use FLAGS_quic_supports_trailers = true #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	net/tools/quic/quic_client_bin.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
	M	net/tools/quic/quic_simple_client_bin.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1531603002 Patch 1

Dependent Patchsets:

Issue 1532113002 Patch 1

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc#newcode130 net/tools/quic/quic_client_bin.cc:130: ValueRestore<bool> old_flag(&FLAGS_quic_supports_trailers, true); No need to do the ValueRestore ...

5 years ago (2015-12-16 15:51:50 UTC) #2

danzh1

On 2015/12/16 15:51:50, Ryan Hamilton wrote: > https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc > File net/tools/quic/quic_client_bin.cc (right): > > https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc#newcode130 ...

5 years ago (2015-12-16 21:26:50 UTC) #3

lgtm

Expand Messages | Collapse Messages