Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1531783002: Turn on the trailers support flag in the toy QUIC client. (Closed)

Created:
5 years ago by danzh1
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@110177994
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on the trailers support flag in the toy QUIC client. n/a (quic toy client) Merge internal change: 110183495 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : use FLAGS_quic_supports_trailers = true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M net/tools/quic/quic_client_bin.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_client_bin.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (0 generated)
danzh1
5 years ago (2015-12-16 14:55:58 UTC) #1
Ryan Hamilton
https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc File net/tools/quic/quic_client_bin.cc (right): https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc#newcode130 net/tools/quic/quic_client_bin.cc:130: ValueRestore<bool> old_flag(&FLAGS_quic_supports_trailers, true); No need to do the ValueRestore ...
5 years ago (2015-12-16 15:51:50 UTC) #2
danzh1
On 2015/12/16 15:51:50, Ryan Hamilton wrote: > https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc > File net/tools/quic/quic_client_bin.cc (right): > > https://codereview.chromium.org/1531783002/diff/1/net/tools/quic/quic_client_bin.cc#newcode130 ...
5 years ago (2015-12-16 21:26:50 UTC) #3
Ryan Hamilton
5 years ago (2015-12-16 22:57:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698