Replace ice_connection_to_client_unittest.cc with connection_unittest.cc

remoting/protocol/fake_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_FAKE_SESSION_H_
 #define REMOTING_PROTOCOL_FAKE_SESSION_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
 #include "remoting/protocol/fake_stream_socket.h"
 #include "remoting/protocol/session.h"
 #include "remoting/protocol/transport.h"
 
 namespace remoting {
 namespace protocol {
 
 extern const char kTestJid[];
 
 class FakeTransport : public Transport {
@@ skipping 12 matching lines @@
   FakeStreamChannelFactory channel_factory_;
 };
 
 // FakeSession is a dummy protocol::Session that uses FakeStreamSocket for all
 // channels.
 class FakeSession : public Session {
  public:
   FakeSession();
   ~FakeSession() override;
 
+  void SimulateConnection(FakeSession* peer);
+
   EventHandler* event_handler() { return event_handler_; }
-
   void set_error(ErrorCode error) { error_ = error; }
-
   bool is_closed() const { return closed_; }
 
   // Session interface.
   void SetEventHandler(EventHandler* event_handler) override;
   ErrorCode error() override;
   const std::string& jid() override;
   const SessionConfig& config() override;
   FakeTransport* GetTransport() override;
   void Close(ErrorCode error) override;
 
  public:

[joedow, 2015/12/17 17:29:11]

not part of your change, but why is public set twice (line 42 and 60)?

Was this meant to be private?

[Sergey Ulanov, 2015/12/17 17:36:18]

Thanks for catching this!

-  EventHandler* event_handler_;
+  EventHandler* event_handler_ = nullptr;
   scoped_ptr<SessionConfig> config_;
 
   std::string jid_;
 
   FakeTransport transport_;
 
-  ErrorCode error_;
-  bool closed_;
+  ErrorCode error_ = OK;
+  bool closed_ = false;
+
+  base::WeakPtr<FakeSession> peer_;
+
+  base::WeakPtrFactory<FakeSession> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeSession);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_FAKE_SESSION_H_