Remove V8WorkerContextErrorHandler.cpp

Remove V8WorkerContextErrorHandler.cpp

- V8WindowErrorHanlder.cpp and V8WorkerContextErrorHandler.cpp are
exactly the same except for how it calls Function::Call().
- This patch removes V8WorkerContextErrorHandler.cpp.
- This patch renames V8WindowErrorHanlder.cpp to V8DOMWindowOrWorkerContextErrorHanlder.cpp.

R=abarth,eseidel

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151874

[haraken, 2013-05-20 02:50:30]

r?

https://codereview.chromium.org/15317004/diff/1/Source/bindings/v8/V8DOMWindo...
File Source/bindings/v8/V8DOMWindowOrWorkerContextErrorHandler.cpp (right):

https://codereview.chromium.org/15317004/diff/1/Source/bindings/v8/V8DOMWindo...
Source/bindings/v8/V8DOMWindowOrWorkerContextErrorHandler.cpp:66: returnValue =
ScriptController::callFunctionWithInstrumentation(0, callFunction, thisValue, 3,
parameters);

I don't fully understand why we pass 0 instead of 'context'. I'll address the
issue in a follow-up patch.

[haraken, 2013-05-20 02:53:09]

https://codereview.chromium.org/15317004/diff/1/Source/bindings/scripts/CodeG...
File Source/bindings/scripts/CodeGeneratorV8.pm (right):

https://codereview.chromium.org/15317004/diff/1/Source/bindings/scripts/CodeG...
Source/bindings/scripts/CodeGeneratorV8.pm:1850: if (($interfaceName eq
"DOMWindow" or $interfaceName eq "WorkerContext") and
$attribute->signature->name eq "onerror") {

Another thing I don't understand is why we treat only DOMWindow.onerror and
WorkerContext.onerror specially. What happens if we treat all onerrors
specially?

[abarth-chromium, 2013-05-20 04:22:03]

I'll have to look at this one again in the morning.

[haraken, 2013-05-20 04:23:56]

Thanks, this patch doesn't change any behavior, although I have a couple of
questions to the current implementation, as I commented above.

[haraken, 2013-05-22 01:59:42]

abarth: could you take a look?

[haraken, 2013-05-30 05:37:44]

abarth: could you take a look?

[eseidel, 2013-06-04 06:31:31]

abarth got lost on the way to the review it seems.

[abarth-chromium, 2013-06-04 06:42:54]

On 2013/06/04 06:31:31, eseidel wrote:
> abarth got lost on the way to the review it seems.

Yeah, this is one of the five or so CLs I'm failing to review currently.  Let me
try now.

[abarth-chromium, 2013-06-04 06:45:29]

LGTM

Sorry this CL took so long to review.  I'm not sure why I was afraid of it.

https://codereview.chromium.org/15317004/diff/1/Source/bindings/v8/V8DOMWindo...
File Source/bindings/v8/V8DOMWindowOrWorkerContextErrorHandler.h (right):

https://codereview.chromium.org/15317004/diff/1/Source/bindings/v8/V8DOMWindo...
Source/bindings/v8/V8DOMWindowOrWorkerContextErrorHandler.h:40: class
V8DOMWindowOrWorkerContextErrorHandler : public V8EventListener {
Why not just call this V8ErrorHander ?  There isn't anything besides DOMWindow
and Workers.  :)

[haraken, 2013-06-04 07:00:55]

Thanks for reviewing!

>
https://codereview.chromium.org/15317004/diff/1/Source/bindings/v8/V8DOMWindo...
> Source/bindings/v8/V8DOMWindowOrWorkerContextErrorHandler.h:40: class
> V8DOMWindowOrWorkerContextErrorHandler : public V8EventListener {
> Why not just call this V8ErrorHander ?  There isn't anything besides DOMWindow
> and Workers.  :)

That's the question I wrote in #2. Currently this error handler is installed on
onerror events on DOMWindow and WorkerContext only. I'm not sure why we don't
install it for all onerror events.

Either way, I'll rename it but keep the current behavior in this CL.

[abarth-chromium, 2013-06-04 07:05:02]

On 2013/05/20 02:53:09, haraken wrote:
> Another thing I don't understand is why we treat only DOMWindow.onerror and
> WorkerContext.onerror specially. What happens if we treat all onerrors
> specially?

The ones on the global objects are special because they're catch-alls for
JavaScript exceptions.  They might have other magical properties.

[haraken, 2013-06-04 07:13:54]

> The ones on the global objects are special because they're catch-alls for
> JavaScript exceptions.  They might have other magical properties.

Makes sense. Thanks!

[commit-bot: I haz the power, 2013-06-05 17:46:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15317004/14001

[commit-bot: I haz the power, 2013-06-05 18:06:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-05 20:02:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/15317004/23001

[commit-bot: I haz the power, 2013-06-05 23:43:30]

Change committed as 151874