Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1531683006: [NaCl SDK] Remove references to naclports bundle (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove references to naclports bundle CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/937645f55be580c4df98ff20455e4dec3918a73e Cr-Commit-Position: refs/heads/master@{#366028}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -77 lines) Patch
M native_client_sdk/doc_generated/cds2014/python.html View 1 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 1 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part1.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/doc_generated/faq.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/doc_generated/reference/ideas.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/doc_generated/reference/pnacl-c-cpp-language-support.html View 1 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/README.naclports View 1 chunk +0 lines, -14 lines 0 comments Download
M native_client_sdk/src/build_tools/build_paths.py View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 2 chunks +1 line, -4 lines 0 comments Download
M native_client_sdk/src/doc/cds2014/python.rst View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 2 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial/tutorial-part1.rst View 1 chunk +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/faq.rst View 4 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/doc/reference/ideas.rst View 1 chunk +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/reference/pnacl-c-cpp-language-support.rst View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/lua/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 3 chunks +5 lines, -9 lines 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1536883002 Patch 1

Messages

Total messages: 14 (7 generated)
Sam Clegg
5 years ago (2015-12-17 23:37:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531683006/1
5 years ago (2015-12-17 23:41:06 UTC) #5
binji
lgtm, as long as you update the generated html
5 years ago (2015-12-18 00:12:26 UTC) #6
Sam Clegg
added re-generated docs
5 years ago (2015-12-18 00:43:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531683006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531683006/20001
5 years ago (2015-12-18 02:54:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 06:23:37 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-18 06:24:27 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/937645f55be580c4df98ff20455e4dec3918a73e
Cr-Commit-Position: refs/heads/master@{#366028}

Powered by Google App Engine
This is Rietveld 408576698