[IC] Fix "compatible receiver" checks hidden behind interceptors

[IC] Fix "compatible receiver" checks hidden behind interceptors

BUG=chromium:497632
LOG=y

Committed: https://crrev.com/cfbd16172fa165cc33ce0e2e72f74e5561168a61
Cr-Commit-Position: refs/heads/master@{#32945}

[Jakob Kummerow, 2015-12-17 11:36:30]

jkummerow@chromium.org changed reviewers:
+ jochen@chromium.org, verwaest@chromium.org

[Jakob Kummerow, 2015-12-17 11:36:31]

PTAL.

I'm not a huge fan of the design of this system (repeating slight variations of
the same check in UpdateCaches, CompileHandler, and CompileLoadInterceptor), but
I think this patch is the right thing to do short-term: fix the bug ASAP,
refactoring can follow later if we want.

https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc#newcode975
src/ic/ic.cc:975: bool IsCompatibleReceiver(LookupIterator* lookup, Handle<Map>
receiver_map) {
This is factored out from below.

[Toon Verwaest, 2015-12-17 11:40:24]

lgtm

[jochen (gone - plz use gerrit), 2015-12-17 11:43:46]

jochen@chromium.org changed reviewers:
+ epertoso@chromium.org, vogelheim@chromium.org

[jochen (gone - plz use gerrit), 2015-12-17 11:43:46]

+epertoso/vogelheim fyi

https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc#newcode1175
src/ic/ic.cc:1175: if (v8::ToCData<Address>(info->getter()) == 0) break;
also use IsCompatibleReceiver() here?

[jochen (gone - plz use gerrit), 2015-12-17 11:49:12]

lgtm

[Jakob Kummerow, 2015-12-17 12:04:18]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2015-12-17 12:04:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531583005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531583005/1

[commit-bot: I haz the power, 2015-12-17 12:28:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-17 12:29:20]

Description was changed from

==========
[IC] Fix "compatible receiver" checks hidden behind interceptors

BUG=chromium:497632
LOG=y
==========

to

==========
[IC] Fix "compatible receiver" checks hidden behind interceptors

BUG=chromium:497632
LOG=y

Committed: https://crrev.com/cfbd16172fa165cc33ce0e2e72f74e5561168a61
Cr-Commit-Position: refs/heads/master@{#32945}
==========

[commit-bot: I haz the power, 2015-12-17 12:29:21]

Patchset 1 (id:??) landed as
https://crrev.com/cfbd16172fa165cc33ce0e2e72f74e5561168a61
Cr-Commit-Position: refs/heads/master@{#32945}