Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(30)

Issue 1531583005: [IC] Fix "compatible receiver" checks hidden behind interceptors (Closed)

Created:
3 years, 5 months ago by Jakob Kummerow
Modified:
3 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[IC] Fix "compatible receiver" checks hidden behind interceptors BUG=chromium:497632 LOG=y Committed: https://crrev.com/cfbd16172fa165cc33ce0e2e72f74e5561168a61 Cr-Commit-Position: refs/heads/master@{#32945}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -29 lines) Patch
M src/ic/ic.cc View 2 chunks +47 lines, -29 lines 2 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
PTAL. I'm not a huge fan of the design of this system (repeating slight variations ...
3 years, 5 months ago (2015-12-17 11:36:31 UTC) #2
Toon Verwaest
lgtm
3 years, 5 months ago (2015-12-17 11:40:24 UTC) #3
jochen (gone - plz use gerrit)
+epertoso/vogelheim fyi https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc File src/ic/ic.cc (right): https://codereview.chromium.org/1531583005/diff/1/src/ic/ic.cc#newcode1175 src/ic/ic.cc:1175: if (v8::ToCData<Address>(info->getter()) == 0) break; also use ...
3 years, 5 months ago (2015-12-17 11:43:46 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 5 months ago (2015-12-17 11:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531583005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531583005/1
3 years, 5 months ago (2015-12-17 12:04:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 5 months ago (2015-12-17 12:28:26 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2015-12-17 12:29:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfbd16172fa165cc33ce0e2e72f74e5561168a61
Cr-Commit-Position: refs/heads/master@{#32945}

Powered by Google App Engine
This is Rietveld 408576698