[Chromecast] Adding pause/resume operations to VideoPlaneController.

chromecast/media/base/video_plane_controller.h

Index: chromecast/media/base/video_plane_controller.h
diff --git a/chromecast/media/base/video_plane_controller.h b/chromecast/media/base/video_plane_controller.h
index 302c8fa4341c2f6a202244b34c5b203bdce4269f..f5b2cb5ddc296f5a1b75230f95e920c7f867cbd4 100644
--- a/chromecast/media/base/video_plane_controller.h
+++ b/chromecast/media/base/video_plane_controller.h
@@ -44,6 +44,9 @@ class VideoPlaneController {
   // If there is no change to video plane parameters from the last call to this
   // method, it is a no-op.
   void SetGeometry(const RectF& display_rect, VideoPlane::Transform transform);
+  // Posts call to VideoPlane::SetGeometry with most recent resolution and
+  // geometry parameters (assuming they are all set). Use to reset video plane.
+  void ResetGeometry();

[halliwell, 2015/12/28 22:22:31]

nit: blank line before comment.

I don't quite like 'ResetGeometry' function name.  It makes it sound like the
geometry is being reset to a default or initial value.

How about something like ApplyToVideoPlane?  Or even ResetVideoPlane.

[esum, 2016/01/11 16:28:57]

Method no longer needed since resetting the video plane is now an automatic part
of Resume() per Derek's comment:
https://eureka-internal-review.git.corp.google.com/#/c/42141/4/service/resour...

 
   // Sets physical screen resolution.  This must be called at least once when
   // the final output resolution (HDMI signal or panel resolution) is known,
@@ -58,6 +61,15 @@ class VideoPlaneController {
   // no-op.
   void SetGraphicsPlaneResolution(const Size& resolution);
 
+  // After Pause is called, no further calls to VideoPlane::SetGeometry will be
+  // made except for any pending calls already scheduled on the media thread.
+  // The Set methods will however update cached parameters that will take
+  // effect once the class is resumed. Safe to call multiple times.
+  void Pause();
+  // Makes class active again. Safe to call multiple times.
+  void Resume();
+  bool is_paused() const;
+
  private:
   class RateLimitedSetVideoPlaneGeometry;
   friend struct base::DefaultSingletonTraits<VideoPlaneController>;
@@ -73,6 +85,8 @@ class VideoPlaneController {
   // VideoPlane::SetGeometry.
   bool HaveDataForSetGeometry() const;
 
+  bool is_paused_;
+
   // Current resolutions
   bool have_output_res_;
   bool have_graphics_res_;